Style Panel CSS properties are limited to hard coded values

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jwalker, Assigned: miker)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

CssHtmlTree contains a list of StyleGroupView items which group CSS properties. This list could easily get out of date.

(dolske) I think you really need a way to dynamically get a list of all known-to-Gecko CSS properties (which I believe are common to all elements?), group the ones this code knows about, and then plop everything else into this "Other" group. Alternatively, write a test that looks at these tables and fails when an new (unknown) property is added.

The problem here is that no one is going to remember to modify this code when new CSS properties are added in the future. So, either a test is needed to ensure people know to do that, or new properties should automatically show up somewhere generic (at which point users would presumably notice and file a bug to clean up the UI).
Blocks: 586984
Depends on: 582596

Updated

7 years ago
Whiteboard: [kd4b7]

Updated

7 years ago
Whiteboard: [kd4b7]
Created attachment 528819 [details]
Complete list of used and unused official and unofficial CSS properties sorted into groups

Complete list of used and unused official and unofficial CSS properties sorted
into groups.

The shorthand properties still need to be removed from the list.

A large amount of these properties can be found in
/layout/style/test/property_database.js but others were gathered from CSS 1, 2 & 3
standards websites.

Using this method we can categorize most properties. It would still be good to put any remaining CSS properties under the "Effects and Other" category.

Looking at the number of attributes in "Effects and Other" maybe we should split this into more categories?
Summary: csshtmltree needs a way to keep up with CSS changes → Style Panel CSS properties are limited to hard coded values
Duplicate of this bug: 651443
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Created attachment 530312 [details] [diff] [review]
Unsupported properties to be moved to "other" group
Comment on attachment 530312 [details] [diff] [review]
Unsupported properties to be moved to "other" group

This patch has been added to the patch in bug 582596 to speed up the review process
Attachment #530312 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.