As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 591611 - Clean up FIREFOX_VERSION handling
: Clean up FIREFOX_VERSION handling
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Ed Morley [:emorley]
: Gregory Szorc [:gps]
Depends on: 591387
  Show dependency treegraph
Reported: 2010-08-28 06:29 PDT by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2011-08-24 09:03 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (3.54 KB, patch)
2011-05-26 11:49 PDT, Ed Morley [:emorley]
khuey: review+
Details | Diff | Splinter Review

Description User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2010-08-28 06:29:13 PDT

Comment 1 User image Ed Morley [:emorley] 2011-05-07 11:19:26 PDT
Kyle, I'm presuming this is referring to bug 591387 comment 21? I'm slighly confused however due to bug 591387 comment 26 and also the fact that there is already:

I'm happy to do this cleanup, just unclear at present what of:
...needs changing to what.

Comment 2 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-05-07 12:53:29 PDT
MOZ_UA_FIREFOX_VERSION is something that's semantically different, even if it has the same value (it also has quotes).

I'd like to not touch that, and instead AC_DEFINE_UNQUOTED(FIREFOX_VERSION,$FIREFOX_VERSION).

Once that's done, any makefile that does something like


can have that bit removed.

As for bug 591387 comment 26, we can remove the AC_SUBST(MOZ_UA_FIREFOX_VERSION ...) and remove the bit.

I would of course be happy to review.
Comment 3 User image Ed Morley [:emorley] 2011-05-26 11:49:33 PDT
Created attachment 535422 [details] [diff] [review]
Patch v1

- Removes |AC_SUBST(MOZ_UA_FIREFOX_VERSION)| in both configure.ins and the corresponding |MOZ_UA_FIREFOX_VERSION = @FIREFOX_VERSION@| in , since MOZ_UA_FIREFOX_VERSION is not used in a Makefile anywhere (

- Adds |AC_DEFINE_UNQUOTED(FIREFOX_VERSION,$FIREFOX_VERSION)| to /, and then removes all |-DFIREFOX_VERSION=$(FIREFOX_VERSION)| ( since they are now redundant.
Comment 4 User image Ed Morley [:emorley] 2011-05-26 13:40:05 PDT
Comment 5 User image Dão Gottwald [:dao] 2011-05-28 05:50:12 PDT
Comment 6 User image Simona B [:simonab ] 2011-08-24 05:42:45 PDT
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Is there any way I can verify this?

I looked in the files in the repo:

Is that enough to mark this as VERIFIED FIXED?


Note You need to log in before you can comment on or make changes to this bug.