try parameter "--build opt" yields debug builds

RESOLVED WONTFIX

Status

Release Engineering
General
RESOLVED WONTFIX
8 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
My latest push to try [1] had the following commit message:

  Bug 573948: Use libjpeg-turbo instead of libjpeg. try: --build opt --p all --m none --u none --t none 

However, I'm apparently getting debug, not opt builds.

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/jlebar@mozilla.com-4204d562ef4f/

[1] http://hg.mozilla.org/try/rev/4204d562ef4f
IIRC you should use '--build  o'. Which doc says opt ?
(Reporter)

Comment 2

8 years ago
Well, that could certainly be the problem.

https://wiki.mozilla.org/Build:TryChooser says

  "Build Types: both(do) || opt(o) || debug(d) || m-c all override (all)"

and I thought this meant that "both", "opt", and "debug" were aliases for "do", "o", and "d".  But perhaps not.

Not to take us off topic, but I find the syntax a bit strange in general.  Why is it --build and not --b when all the other flags are just one letter?  And why do the one-letter flags get two dashes instead of just one?  Something with long and short-form flags and options would feel more familiar to me.
(Reporter)

Comment 3

8 years ago
I'd be happy to close this as WORKSFORME if we update the wiki page to be more explicit.  I'd do it myself, but I'm still not sure I understand all the options.  (What's "m-c all override"?)

I can file a separate bug for making the syntax more familiar.  See also Bug 591688.
(Reporter)

Comment 4

8 years ago
I filed Bug 591690 for the syntax gripes.
Other bug is addressing some of these concerns, as well as the bug on user input validation via hg commit hook so closing this as WONTFIX since the syntax does not claim that --build opt should in fact yield opt builds (it's --build o right now).
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 6

8 years ago
The bug here really is that the line

  "Build Types: both(do) || opt(o) || debug(d) || m-c all override (all)"

in the documentation is confusing.  I've updated the wiki page.
Thanks Justin - your help in ironing out issues with this new feature is greatly appreciated.
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.