591686 - try parameter "--build opt" yields debug builds

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

My latest push to try [1] had the following commit message:

  Bug 573948: Use libjpeg-turbo instead of libjpeg. try: --build opt --p all --m none --u none --t none 

However, I'm apparently getting debug, not opt builds.

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-4204d562ef4f/

[1] http://hg.mozilla.org/try/rev/4204d562ef4f

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

IIRC you should use '--build  o'. Which doc says opt ?

Comment 2

[Justin Lebar (not reading bugmail)]

Well, that could certainly be the problem.

https://wiki.mozilla.org/Build:TryChooser says

  "Build Types: both(do) || opt(o) || debug(d) || m-c all override (all)"

and I thought this meant that "both", "opt", and "debug" were aliases for "do", "o", and "d".  But perhaps not.

Not to take us off topic, but I find the syntax a bit strange in general.  Why is it --build and not --b when all the other flags are just one letter?  And why do the one-letter flags get two dashes instead of just one?  Something with long and short-form flags and options would feel more familiar to me.

Comment 3

[Justin Lebar (not reading bugmail)]

I'd be happy to close this as WORKSFORME if we update the wiki page to be more explicit.  I'd do it myself, but I'm still not sure I understand all the options.  (What's "m-c all override"?)

I can file a separate bug for making the syntax more familiar.  See also Bug 591688.

Comment 4

[Justin Lebar (not reading bugmail)]

I filed Bug 591690 for the syntax gripes.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Other bug is addressing some of these concerns, as well as the bug on user input validation via hg commit hook so closing this as WONTFIX since the syntax does not claim that --build opt should in fact yield opt builds (it's --build o right now).

Comment 6

[Justin Lebar (not reading bugmail)]

The bug here really is that the line

  "Build Types: both(do) || opt(o) || debug(d) || m-c all override (all)"

in the documentation is confusing.  I've updated the wiki page.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Thanks Justin - your help in ironing out issues with this new feature is greatly appreciated.