591783 - Can't install language packs in the latest nightlies (file appears to be corrupt)

Status: VERIFIED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Francesco Lodolo [:flod]]

If I try to install a language pack from ftp.mozilla.org (also the en-US one from firefox/nightly/latest-mozilla-central) I get this error: "The add-on downloaded from ftp.mozilla.org could not be installed because it appears to be corrupt". Same error if I download the file and try a local install.

Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100829 Firefox/4.0b5pre

This is happening also on a 20100827 Build.

The language pack seems to be fine, the only difference with a mozilla-1.9.2 language pack is that the content is not included in a .jar file (but the chrome.manifest seems to be updated for this).

I'm opening this bug in Firefox General because I honestly don't know which component would be more appropriate.

Comment 1

[Axel Hecht [:Pike]]

I'm pretty sure this is a dupe of bug 591387.

Comment 2

[Scoobidiver (away)]

Bug 591387 is fixed in Minefield/20100829 and I checked in AOM that it is.

Comment 3

[Axel Hecht [:Pike]]

This is build config, and it's the same bug as bug 591387. If that's not FIXED, we'll need to reopen it.

Comment 4

[Dão Gottwald [:dao]]

So where's the source for this, where's the install.rdf file in particular generated from?

Comment 5

[Axel Hecht [:Pike]]

Oops, there is a difference.

http://mxr.mozilla.org/mozilla-central/source/browser/locales/generic/install.rdf uses MOZ_APP_VERSION, theme uses FIREFOX_VERSION.

http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.mk#86 is the callsite.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 470390 [details] [diff] [review]
patch

This looks ok to me.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Landing this requires backing out 591412.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Also, we can lose the AC_SUBST.

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #9)
> Landing this requires backing out 591412.

done

http://hg.mozilla.org/mozilla-central/rev/0f7c277c48d6
http://hg.mozilla.org/mozilla-central/rev/02c50330c493

(In reply to comment #10)
> Also, we can lose the AC_SUBST.

done

http://hg.mozilla.org/mozilla-central/rev/2936cee40d18

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100831 Firefox/4.0b5pre

Before we have an automated test I'm sure we will have at least one manual and Mozmill test for it.