591849 - Not polling mobile-browser for Android builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

[I don't normally work on this stuff, this could be deliberate]

blassey asked for an Android build (tip of mozilla-central & mobile-brower) because one hadn't been triggered on a m-b push. Looking back on the last 15 or so 'Android R7 mozilla-central build' jobs on pm01/03, they're all triggered by changes in m-c. The scheduler master on pm01 is also not polling m-b. For the maemo builds we trigger jobs on either repo.

jhford, aki ?

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

apparently, the last change from m-b in scheduler-db is from july 2.  At the same time, http://hg.mozilla.org/build/buildbotcustom/diff/b634f09d2940/misc.py went in (Mobile on tryserver).

I wonder if the scheduler is being created and hooked up properly (mobile-browser-mozilla-central-build-mobile as one example)

It seems like the relevant code is around http://hg.mozilla.org/build/buildbotcustom/annotate/b53de29ee6a9/misc.py#l2250

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: testing patch

This patch demonstrates that there scheduler isn't being created properly.

sample output from checkconfig:
Not creating a scheduler for shadow-central
Not creating a scheduler for jaegermonkey
Not creating a scheduler for tracemonkey
Not creating a scheduler for tryserver
Not creating a scheduler for cedar
Not creating a scheduler for birch
Not creating a scheduler for maple
Not creating a scheduler for electrolysis
Not creating a scheduler for places
Not creating a scheduler for mozilla-central
Config file is good!

The only line that is valid is that is valid is the one for tryserver

Changing if not config.get('enable_try', True): to if not config.get('enable_try', False): provides the following output:

Creating mobile scheduler for shadow-central
Creating mobile scheduler for jaegermonkey
Creating mobile scheduler for tracemonkey
Not creating a scheduler for tryserver
Creating mobile scheduler for cedar
Creating mobile scheduler for birch
Creating mobile scheduler for maple
Creating mobile scheduler for electrolysis
Creating mobile scheduler for places
Creating mobile scheduler for mozilla-central
Config file is good!

This is valid output.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: the fix

This patch fixes the issue by starting to create mobile-browser schedulers again

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 470368 [details] [diff] [review]
the fix

http://hg.mozilla.org/build/buildbotcustom/rev/12abe89aeb53