591885 - Test cases should be upgraded to use USES_BUGCOMPAT

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

A few test cases still have individual -bugcompat flags in the avm_args file, they should be rewritten to use USES_BUGCOMPAT.

Bug #590879 will change those flags to be -swfversion, this bug should wait on that bug to land.

The tests I know about are:

$ grep swfversion $(find . -name '*.as.avm_args')

test/acceptance/as3/Vector/bug504525/bug504525a.as.avm_args:-swfversion 9
test/acceptance/as3/Vector/bug504525/bug504525b.as.avm_args:-swfversion 10
test/acceptance/as3/Vector/bug504525/bug504525c.as.avm_args:-swfversion 11
test/acceptance/ecma3/GlobalObject/parseFloat_513018a.as.avm_args:-swfversion 9
test/acceptance/ecma3/GlobalObject/parseFloat_513018b.as.avm_args:-swfversion 11
test/acceptance/ecma3/String/localeCompare_585791a.as.avm_args:-swfversion 9
test/acceptance/ecma3/String/localeCompare_585791b.as.avm_args:-swfversion 11

Comment 1

[Chris Peyer]

Attachment: Update any tests that use versioning to use USES_SWFVERSION

1. replace all uses of USES_BUGCOMPAT with USES_SWFVERSION (see Bug 590879)
2. replace tests that use individual -swfversion avm_args files to use the future compatible USES_SWFVERSION

Comment 2

[James Sudduth]

Comment on attachment 470904 [details] [diff] [review]
Update any tests that use versioning to use USES_SWFVERSION

Looks good - just pull out the unrelated metricinfo.py code.

Comment 3

[Chris Peyer]

Pushed to redux -metricinfo stuffs:

http://hg.mozilla.org/tamarin-redux/rev/41ee7ef53bab