591973 - Persisted window location might be restored to an off-screen location

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Wladimir Palant]

This issue can be reproduced with Adblock Plus but should affect other extensions as well. Steps to reproduce:

1. Install Adblock Plus 1.2.2
2. In Firefox 4: Open Add-on Manager. If you want to compare properly in Firefox 3.6: Open chrome://mozapps/content/extensions/extensions.xul in a tab.
3. Resize your browser window to occupy only half of the screen and move it to the left edge of the screen.
4. Right-click Adblock Plus entry in the add-on manager and choose "Options". Move the options window to the right edge of the screen and close it.
5. Now move the browser window to the right edge of the screen and open Adblock Plus options again.

Expected results:

The options window still opens within screen boundaries despite all position persistence. That's the result I see in Firefox 3.6.8

Actual results:

What I see with the current nightly (Gecko/20100829 Firefox/4.0b5pre on Windows 7 x64): The window is almost invisible, the left edge of it is barely visible at the right edge of the screen. In fact, this was reported as a hang caused by Adblock Plus - add-on manager opens options as a modal dialog, the browser window is unusable until that dialog is closed.

Comment 1

[Jim Mathies [:jimm]]

There's code in widget designed to prevent windows from being opened off screen. How much of the options dialog is visible? Can you post a screen shot?

Comment 2

[Benjamin Smedberg]

Please renominate if more data becomes available.

Comment 3

[Wladimir Palant]

Attachment: Screenshot

See screenshot. I clicked Options for the Adblock Plus extension, the window is barely visible on the right edge of the screen - only 7 pixel, the width of the window border.

Comment 4

[Jim Mathies [:jimm]]

yet another side effect from the patch in bug 574690, which I'm planning to
back out.

Comment 5

[Jim Mathies [:jimm]]

The patch that caused this (bug 574690) has been backed out. Should be fixed in tomorrow's nightly.

Comment 6

[Wladimir Palant]

Confirmed, works for me in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101017 Firefox/4.0b8pre.