AppendPrintf truncates output to 31 ASCII characters

RESOLVED FIXED in mozilla9

Status

()

Core
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Trunk
mozilla9
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
I got caught by this in bug 586048
(Assignee)

Comment 1

7 years ago
Created attachment 470521 [details] [diff] [review]
Use vsmprintf to overcome this limitation
(Assignee)

Comment 2

6 years ago
Created attachment 554433 [details] [diff] [review]
Use vsmprintf to overcome this limitation v2

This time I've done a quick audit of all the users and none of them look performance critical, thus I've made AppendPrintf31 private.
Attachment #470521 - Attachment is obsolete: true
Attachment #554433 - Flags: review?(benjamin)
Comment on attachment 554433 [details] [diff] [review]
Use vsmprintf to overcome this limitation v2

It appears to me that nsTSubstring_CharT::AppendPrintf leaks its buffer: doesn't it need to call PR_smprintf_free on it? r=me with that change
Attachment #554433 - Flags: review?(benjamin) → review+

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/548e34a4a9c2
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.