Last Comment Bug 592009 - AppendPrintf truncates output to 31 ASCII characters
: AppendPrintf truncates output to 31 ASCII characters
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla9
Assigned To: Jeff Muizelaar [:jrmuizel]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-30 12:31 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-08-25 18:43 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use vsmprintf to overcome this limitation (4.51 KB, patch)
2010-08-30 12:45 PDT, Jeff Muizelaar [:jrmuizel]
no flags Details | Diff | Splinter Review
Use vsmprintf to overcome this limitation v2 (4.50 KB, patch)
2011-08-19 08:53 PDT, Jeff Muizelaar [:jrmuizel]
benjamin: review+
Details | Diff | Splinter Review

Description Jeff Muizelaar [:jrmuizel] 2010-08-30 12:31:35 PDT
I got caught by this in bug 586048
Comment 1 Jeff Muizelaar [:jrmuizel] 2010-08-30 12:45:56 PDT
Created attachment 470521 [details] [diff] [review]
Use vsmprintf to overcome this limitation
Comment 2 Jeff Muizelaar [:jrmuizel] 2011-08-19 08:53:05 PDT
Created attachment 554433 [details] [diff] [review]
Use vsmprintf to overcome this limitation v2

This time I've done a quick audit of all the users and none of them look performance critical, thus I've made AppendPrintf31 private.
Comment 3 Benjamin Smedberg [:bsmedberg] 2011-08-24 09:17:20 PDT
Comment on attachment 554433 [details] [diff] [review]
Use vsmprintf to overcome this limitation v2

It appears to me that nsTSubstring_CharT::AppendPrintf leaks its buffer: doesn't it need to call PR_smprintf_free on it? r=me with that change
Comment 4 Ed Morley [:emorley] 2011-08-25 18:43:14 PDT
http://hg.mozilla.org/mozilla-central/rev/548e34a4a9c2

Note You need to log in before you can comment on or make changes to this bug.