Closed Bug 592018 Opened 14 years ago Closed 14 years ago

navigation arrows should be dimmed when they are disabled

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b7
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: eyalgruss, Assigned: rjohnson19)

References

Details

(Whiteboard: [AOMTestday][in-litmus-bug-week][good first bug])

Attachments

(2 files)

Screenshot (Win7)
1.76 KB, image/png
Details
patch
993 bytes, patch
mossop
: review+
Details | Diff | Splinter Review 
navigation arrows should be dimmed when they are disabled, just like the url navigation arrows.
Blocks: 553470
What OS are you testing with? They are dimmed for me.
No longer blocks: 553470
XP SP3
Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100830 Firefox/4.0b5pre
clean profile
Attached image Screenshot (Win7) — 
The buttons are disabled, but the icons remain the same. I didn't consider this an issue when testing, but I guess its a little inconsistent with other similar buttons in other parts of the UI.
Looks like I only did the dimming on OSX
blocking2.0: --- → final+
Whiteboard: [good first bug]
Attached patch patch — — Splinter Review 
Use the same disabled button style on Windows as on OS X.
Attachment #472588 - Flags: review?(dtownsend)
Comment on attachment 472588 [details] [diff] [review]
patch

Awesome, thanks
Attachment #472588 - Flags: review?(dtownsend) → review+
Assignee: nobody → rjohnson19
Blocks: 590175
Landed, thanks for the patch: http://hg.mozilla.org/mozilla-central/rev/e736b967e199
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug] → [AOMTestday][in-litmus-bug-week][good first bug]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: