Closed
Bug 592018
Opened 14 years ago
Closed 14 years ago
navigation arrows should be dimmed when they are disabled
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: eyalgruss, Assigned: rjohnson19)
References
Details
(Whiteboard: [AOMTestday][in-litmus-bug-week][good first bug])
Attachments
(2 files)
|
1.76 KB,
image/png
|
Details | |
|
993 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Screenshot (Win7)
navigation arrows should be dimmed when they are disabled, just like the url navigation arrows.
|
||
Comment 1•14 years ago
|
||
What OS are you testing with? They are dimmed for me.
No longer blocks: 553470
|
Reporter | |
Comment 2•14 years ago
|
||
XP SP3
Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100830 Firefox/4.0b5pre
clean profile
|
||
Comment 3•14 years ago
|
||
The buttons are disabled, but the icons remain the same. I didn't consider this an issue when testing, but I guess its a little inconsistent with other similar buttons in other parts of the UI.
|
|
||
Updated•14 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 5•14 years ago
|
||
Use the same disabled button style on Windows as on OS X.
Attachment #472588 -
Flags: review?(dtownsend)
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 472588 [details] [diff] [review]
patch
Awesome, thanks
Attachment #472588 -
Flags: review?(dtownsend) → review+
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Assignee: nobody → rjohnson19
|
|
||
Comment 7•14 years ago
|
||
Landed, thanks for the patch: http://hg.mozilla.org/mozilla-central/rev/e736b967e199
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 8•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug] → [AOMTestday][in-litmus-bug-week][good first bug]
You need to log in
before you can comment on or make changes to this bug.
Description
•