Closed Bug 592133 Opened 14 years ago Closed 14 years ago

Installer includes "Minefield is a Trademark of The Mozilla Foundation" when not using official branded

Categories

(Firefox :: Installer, defect)

All
Windows 7
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 4.0b7

People

(Reporter: clokep, Unassigned)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:2.0b5pre) Gecko/20100830 Firefox/4.0b5pre
Build Identifier: 

The Windows installer hard codes a string into the setup.exe (which is not very discoverable since most users won't un-zip this from the installer) and in helper.exe which is part of the uninstaller.  The string that is hard coded is "${BrandShortName} is a Trademark of The Mozilla Foundation." and occurs even for nightly builds (i.e. "Shredder" or "Minefield").

This also affects other applications using mozilla-central, i.e. this file is also patched for Instantbird (as it is not a trademark of Mozilla): http://lxr.instantbird.org/instantbird/source/tools/patches/installer-trademark.patch

Reproducible: Always

Actual Results:  
This string is always used in the installer.

Expected Results:  
This string is only used when official branding is used.

A possible fix would be to ignore this string using an ifdef unless official branding is enabled.
Regarding InstantBird or any non Mozilla app all they have to do is not include version.nsh and add their own VIAddVersionKey... version.nsh is opt-in.

johnath, what do you think?
Hey Jim, I've thought about moving the version info into defines.nsi.in in the past and this bug provides all the more reason to do so. If the other apps decide to move the values over to their defines.nsi.in the version.nsh file can then be removed which cleans things up a tad.
Assignee: nobody → robert.bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #470696 - Flags: review?(jmathies)
Attachment #470696 - Flags: review?(jmathies) → review+
Assignee: robert.bugzilla → nobody
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
QA Contact: nsis.installer → installer
Version: unspecified → Trunk
Comment on attachment 470696 [details] [diff] [review]
simple patch rev1

Hey Mike, this makes it so the installer / uninstaller do not have the LegalTrademarks file property when not using official branding and I wanted to make sure you are ok with this.
Attachment #470696 - Flags: ui-review?(beltzner)
Comment on attachment 470696 [details] [diff] [review]
simple patch rev1

Mike, forgot to ask that if you are ok with this and ok with it landing for Firefox 4 could you please give it approval2.0 as well. Thanks
Attachment #470696 - Flags: approval2.0?
Comment on attachment 470696 [details] [diff] [review]
simple patch rev1

uir+a=beltzner
Attachment #470696 - Flags: ui-review?(beltzner)
Attachment #470696 - Flags: ui-review+
Attachment #470696 - Flags: approval2.0?
Attachment #470696 - Flags: approval2.0+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/556f27f56d14
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Blocks: 760988
You need to log in before you can comment on or make changes to this bug.