Closed
Bug 592157
Opened 15 years ago
Closed 15 years ago
Links on Safe Browsing blocked site overlay aren't visibly differentiated if user has "Underline links" off
Categories
(Camino Graveyard :: Security, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: phiw2)
Details
(Whiteboard: [camino-2.0.5])
Attachments
(2 files)
|
845 bytes,
patch
|
alqahira
:
review+
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
|
108.84 KB,
image/png
|
Details |
Screenshot in 2.0.x with underlining off
Not sure how this slipped through :(
|
Assignee | |
Comment 1•15 years ago
|
||
Use the default (user set) color (which will be blue for most people)
Assignee: nobody → phiw
|
|
Assignee | |
Updated•15 years ago
|
Attachment #470671 -
Flags: review?(alqahira)
|
Reporter | |
Comment 2•15 years ago
|
||
Comment on attachment 470671 [details] [diff] [review]
fix
Yes, this looks good :)
Attachment #470671 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #470671 -
Flags: review?(alqahira)
Attachment #470671 -
Flags: review+
|
|
Reporter | |
Comment 3•15 years ago
|
||
Here's a screenshot of the patched version in 2.0.x (since we'll want to take it there, IMO), with underlining off.
|
|
Reporter | |
Updated•15 years ago
|
Flags: camino2.0.5?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 470671 [details] [diff] [review]
fix
sr=smorgan
Attachment #470671 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
|
Reporter | |
Comment 5•15 years ago
|
||
http://hg.mozilla.org/camino/rev/a0d0df40aa44 and CAMINO_2_0_BRANCH.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: camino2.0.5? → camino2.0.5+
Resolution: --- → FIXED
Whiteboard: [camino-2.0.5]
You need to log in
before you can comment on or make changes to this bug.
Description
•