Closed Bug 592166 Opened 9 years ago Closed 9 years ago

update a11y mochitest to remove hardcoded chrome://mochikit from test data

Categories

(Core :: Disability Access APIs, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jmaher, Unassigned)

References

Details

Attachments

(1 file)

in getting the browser-chrome tests working on android we need to package the *chrome* style tests into a .jar file.  The solution we have which works best for flexibility and our make system builds two jars: mochikit.jar (an extension for the core harness code) and tests.jar (a zip file of the raw test data).  

In order to get this to work, I have had to make the tests.jar accessed via chrome://mochitests (or anything other than mochikit).  This requires me to change all test files that have chrome://mochikit hardcoded (except for core harness references). 

I have attached a patch which fixes this.  98% of it is very straightforward, and the rest should make sense with the comments or a few minutes reading the code.  This patch is intended to work with the current build tree (without my .jar changes) as well as with my .jar changes.
Attachment #470679 - Flags: review?(bolterbugz)
these tests pass on all the try server runs
Comment on attachment 470679 [details] [diff] [review]
remove test file chrome://mochikit references

r=me, thanks!

>   <script type="application/javascript"
>-          src="chrome://mochikit/content/a11y/accessible/common.js"></script>
>+          src="../common.js"></script>

I wondered if you still need the line break? (but I won't make you change all these)
Attachment #470679 - Flags: review?(bolterbugz) → review+
(In reply to comment #2)

> >   <script type="application/javascript"
> >-          src="chrome://mochikit/content/a11y/accessible/common.js"></script>
> >+          src="../common.js"></script>
> 
> I wondered if you still need the line break? (but I won't make you change all
> these)

some people prefer to keep each argument on own line, this is fine actually, though usually we don't follow this
Landed: http://hg.mozilla.org/mozilla-central/rev/e4df7204de9c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.