592272 - undo close tab produces a blank tab

Status: RESOLVED DUPLICATE of bug 581937

(Firefox :: Session Restore, defect)

Description

[Hemiola SUN]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b4) Gecko/20100818 Firefox/4.0b4
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b4) Gecko/20100818 Firefox/4.0b4

When only one about:blank tab exist, undo close tab will put the about:blank tab into the list of closed tabs.

This doesn't happen on 3.6.x.

Reproducible: Always

Steps to Reproduce:
1. Set browser.tabs.closeWindowWithLastTab to false
2. Open two or more tabs with actual content (mozilla.org, gmail, etc)
3. Close all the tabs, and one blank tab remains
4. Press ctrl-shift-t to undo close tab
5. Press ctrl-shift-t again
Actual Results:  
A blank tab is restored

Expected Results:  
A real tab, instead of the blank one, should be restored.

After the first tab is restored, open History menu and then open "recently closed tabs", a blank tab is listed in the first place.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I know exactly why this broke & we can fix it pretty easily.

Bug 580819 changed something regarding new tabs & about:blank in session history, so we need to change our "empty tab" rule a little bit.

We should definitely fix this for 4.0, but not worth blocking beta 6 I would think.