Closed Bug 592308 Opened 10 years ago Closed 10 years ago

IsLowMemory() is terribly slow and there is nothing to do about it.

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
fennec 2.0+ ---

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

The IsLowMemory predicate allows a piece of code test to see if we are in a low memory situation.  We only do this sort of test in two major places:

1) allocation of image data
2) during js callbacks

Testing for low memory requires us to read proc files, or acquire a kernal lock (like when we have to call into GlobalMemoryStatus on windows).  On Windows CE we disabled this check all together because of the cost.

(1) doesn't really matter that much in terms of perf, but (2) really does.

In addition, some memory allocators do reservations and commit on write.  In this case, the test would not actually do what you wanted.

So, I think we should move away from using IsLowMemory.  Instead, we should continue broadcasting memory-pressure notifications when we can and if the OS has such a feature.  For example, on osso, we get a notification that our process is running low on memory.  We can also detect this on Android.

If this is agreeable, we can remove the IsLowMemory() callers, make the call return false, and add documentation about deprecating this method.
tracking-fennec: --- → ?
OS: Linux → All
Hardware: x86_64 → All
Attached patch patch v.1Splinter Review
Assignee: nobody → doug.turner
Attachment #470824 - Flags: review?(benjamin)
Attachment #470824 - Flags: review?(benjamin) → review+
tracking-fennec: ? → 2.0+
Keywords: dev-doc-needed
http://hg.mozilla.org/mozilla-central/rev/a5d1b45234b8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
You need to log in before you can comment on or make changes to this bug.