592410 - WebConsole: Reloading page while requests are not done causes exception

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Viereck]

When a page hasn't finished loading yet (or at least some of the requests for the page) and you hit the reload button you will sometimes see exceptions like this:

Error: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.visitResponseHeaders]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://gre/modules/HUDService.jsm :: RL_setResponseHeader :: line 166"  data: no]
Source File: resource://gre/modules/HUDService.jsm
Line: 166

Comment 1

[Julian Viereck]

Attachment: Patch v1.0

Another simple fix - no unit tests (which should be fine as that was okay for bug 592264 as well and this fix goes the same way).

Comment 2

[David Dahl :ddahl]

Comment on attachment 470895 [details] [diff] [review]
Patch v1.0

nice catch!

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 470895 [details] [diff] [review]
Patch v1.0

>+        // Accessing the response header can throw an NS_ERROR_NOT_AVAILABLE
>+        // exception. Catch it and stop it to make it not show up in the
>+        // error console. See bug 592410.
Explaining why in the code is more useful than referencing the bug.  Please just explain it here and lose the bug reference.

r=sdwilsh

Comment 4

[Julian Viereck]

Attachment: Patch v1.1

Improved based on Shawn's review.

Comment 5

[Dão Gottwald [:dao]]

Needs approval to land.

Comment 6

[David Dahl :ddahl]

http://hg.mozilla.org/mozilla-central/rev/520233ed37c1