The default bug view has changed. See this FAQ.

Port bug 506175 to SM and fix an intermittent orange on linux for download manager tests

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Testing Infrastructure
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b1
x86
Linux
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

In toolkit bug 506175 a new method for SimpleTest, waitForFocus, was introduced to help fix an intermittent orange they were having on linux tinderboxes for download manager tests.
We should port this to SM.
With patch applied no fails:
228 INFO Passed: 128
229 INFO Failed: 0
230 INFO Todo:   0
Attachment #470894 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
Assignee: nobody → iann_bugzilla

Comment 1

7 years ago
Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

It's a shame that there's no easy way to avoid reindenting much of the code (I assume Firefox did too); a -w diff would have been helpful.

>+  function continueTest(win) {
...
>   };
Nit: [object] variables need trailing semicolons; functions don't.
Attachment #470894 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Blocks: 452942
(Assignee)

Comment 2

7 years ago
Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/0fcd53f9120a
With extra semicolons removed and as much re-indenting avoided as possible.
Attachment #470894 - Attachment description: Use waitForFocus on relevant download manager tests patch → Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Depends on: 506175
Flags: in-testsuite+
On *-1.9.1, some other test was just fixed by porting the trunk patch with s/SimpleTest.waitForFocus()/addLoadEvent()/.
(To hopefully fix bug 515407 and bug 589616.)
status-seamonkey2.1: --- → ?

Comment 4

7 years ago
The seamonkey2.1 flag is not for 2.0!
status-seamonkey2.1: ? → ---
You need to log in before you can comment on or make changes to this bug.