Last Comment Bug 592438 - Port bug 506175 to SM and fix an intermittent orange on linux for download manager tests
: Port bug 506175 to SM and fix an intermittent orange on linux for download ma...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Ian Neal
:
Mentors:
Depends on: 506175
Blocks: SmTestFail
  Show dependency treegraph
 
Reported: 2010-08-31 14:02 PDT by Ian Neal
Modified: 2010-09-01 05:17 PDT (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2] (17.37 KB, patch)
2010-08-31 14:02 PDT, Ian Neal
neil: review+
Details | Diff | Review

Description Ian Neal 2010-08-31 14:02:11 PDT
Created attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

In toolkit bug 506175 a new method for SimpleTest, waitForFocus, was introduced to help fix an intermittent orange they were having on linux tinderboxes for download manager tests.
We should port this to SM.
With patch applied no fails:
228 INFO Passed: 128
229 INFO Failed: 0
230 INFO Todo:   0
Comment 1 neil@parkwaycc.co.uk 2010-08-31 14:21:31 PDT
Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

It's a shame that there's no easy way to avoid reindenting much of the code (I assume Firefox did too); a -w diff would have been helpful.

>+  function continueTest(win) {
...
>   };
Nit: [object] variables need trailing semicolons; functions don't.
Comment 2 Ian Neal 2010-08-31 15:40:06 PDT
Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/0fcd53f9120a
With extra semicolons removed and as much re-indenting avoided as possible.
Comment 3 Serge Gautherie (:sgautherie) 2010-08-31 20:19:11 PDT
On *-1.9.1, some other test was just fixed by porting the trunk patch with s/SimpleTest.waitForFocus()/addLoadEvent()/.
(To hopefully fix bug 515407 and bug 589616.)
Comment 4 Robert Kaiser (not working on stability any more) 2010-09-01 05:17:41 PDT
The seamonkey2.1 flag is not for 2.0!

Note You need to log in before you can comment on or make changes to this bug.