Web Console cleanup: deleteHeadsUpDisplay() should delete the weak reference itself

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: pcwalton, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cleanup] [post-fx-4])

(Reporter)

Description

8 years ago
Instead of:

    delete this.hudWeakReferences[aHUDId].get();

We should have:

    delete this.hudWeakReferences[aHUDId];

Since "delete" has no special functionality in XPCOM, and the reference is weak as it is, the reference count on the XPCOM object should be able to reach zero on its own. We need only delete the weak reference object itself to avoid leaking.
(Reporter)

Comment 1

8 years ago
This has been fixed with the change to strong references.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.