Closed Bug 592510 Opened 14 years ago Closed 14 years ago

Web Console cleanup: deleteHeadsUpDisplay() should delete the weak reference itself

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pcwalton, Unassigned)

References

Details

(Whiteboard: [cleanup] [post-fx-4])

Instead of:

    delete this.hudWeakReferences[aHUDId].get();

We should have:

    delete this.hudWeakReferences[aHUDId];

Since "delete" has no special functionality in XPCOM, and the reference is weak as it is, the reference count on the XPCOM object should be able to reach zero on its own. We need only delete the weak reference object itself to avoid leaking.
This has been fixed with the change to strong references.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.