Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Port changes from toolkit's browser_354894.js to SeaMonkey's browser_bug515006.js

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Testing Infrastructure
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.1b1
x86
Linux
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 470997 [details] [diff] [review]
Port the changes patch v0.1 [Checked in: Comment 2]

There have been various changes to toolkit's test browser_354894.js which we should probably port to SeaMonkey's test browser_bug515006.js
Attachment #470997 - Flags: feedback?(misak.bugzilla)

Updated

7 years ago
Attachment #470997 - Flags: feedback?(misak.bugzilla) → feedback+
(Assignee)

Updated

7 years ago
Attachment #470997 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 470997 [details] [diff] [review]
Port the changes patch v0.1 [Checked in: Comment 2]

>-      if (gPrefService.prefHasUserValue(pref)) {
>+      if (gPrefService.prefHasUserValue(pref))
>         gPrefService.clearUserPref(pref);
>-      }
>     }
>     gPrefService.setBoolPref("browser.tabs.warnOnClose", oldWarnTabsOnClose);
[Odd, they forgot to switch to Services.prefs!]

I haven't actually tried this but the changes look reasonable to me.
Attachment #470997 - Flags: review?(neil) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 470997 [details] [diff] [review]
Port the changes patch v0.1 [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/cd6208fd054a
Included change to use Services.prefs as suggested.
Attachment #470997 - Attachment description: Port the changes patch v0.1 → Port the changes patch v0.1 [Checked in: Comment 2]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Could you s/browser_bug515006.js/browser_354894.js/ while here?
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.