Last Comment Bug 592560 - Port changes from toolkit's browser_354894.js to SeaMonkey's browser_bug515006.js
: Port changes from toolkit's browser_354894.js to SeaMonkey's browser_bug51500...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Ian Neal
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-31 18:23 PDT by Ian Neal
Modified: 2010-09-02 01:04 PDT (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Port the changes patch v0.1 [Checked in: Comment 2] (5.79 KB, patch)
2010-08-31 18:23 PDT, Ian Neal
neil: review+
misak.bugzilla: feedback+
Details | Diff | Splinter Review

Description Ian Neal 2010-08-31 18:23:38 PDT
Created attachment 470997 [details] [diff] [review]
Port the changes patch v0.1 [Checked in: Comment 2]

There have been various changes to toolkit's test browser_354894.js which we should probably port to SeaMonkey's test browser_bug515006.js
Comment 1 neil@parkwaycc.co.uk 2010-09-01 03:03:17 PDT
Comment on attachment 470997 [details] [diff] [review]
Port the changes patch v0.1 [Checked in: Comment 2]

>-      if (gPrefService.prefHasUserValue(pref)) {
>+      if (gPrefService.prefHasUserValue(pref))
>         gPrefService.clearUserPref(pref);
>-      }
>     }
>     gPrefService.setBoolPref("browser.tabs.warnOnClose", oldWarnTabsOnClose);
[Odd, they forgot to switch to Services.prefs!]

I haven't actually tried this but the changes look reasonable to me.
Comment 2 Ian Neal 2010-09-01 05:29:22 PDT
Comment on attachment 470997 [details] [diff] [review]
Port the changes patch v0.1 [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/cd6208fd054a
Included change to use Services.prefs as suggested.
Comment 3 Serge Gautherie (:sgautherie) 2010-09-02 01:04:19 PDT
Could you s/browser_bug515006.js/browser_354894.js/ while here?

Note You need to log in before you can comment on or make changes to this bug.