592595 - Firefox crashed when I updated video card drivers with D2D enabled [@ cairo_d2d_present_backbuffer]

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100831 Firefox/4.0b5pre
Build Identifier: 

I had Firefox running with D2D enabled on Windows 7.

Microsoft Update notified me that I had updates available to install, including an update for my ATI HD5770 graphics card's drivers.

I started the installation. Windows dropped down to low-graphics mode as the driver switched over to the updated version. When it completed the update, Windows switched back to normal resolution. At this point, Firefox crashed.

Reproducible: Always

Steps to Reproduce:
1. Run a D2D-enabled version of Firefox (recent beta or trunk) on Windows Vista/7.
2. Update video card drivers while Firefox is running.
3. Crash.
Actual Results:  
Firefox crashed.

Expected Results:  
Firefox shouldn't have crashed. Some notification that the graphics system failed, perhaps?

Here's the crash report: http://crash-stats.mozilla.com/report/index/bp-9469625b-95d6-4e8f-a54d-bcc7c2100831

Comment 1

[Bas Schouten (:bas.schouten)]

Hrm, looks like we can call Present on an error surface, we should check for error surfaces being returned in OnPaint, probably.

Comment 2

[Scoobidiver (away)]

It also happened to me.

Comment 3

[chris hofmann]

volume on this has risen steadly as number of users on b5 increases.

20100905 12 ,5 4.0b6pre2010090404 ,1 4.0b5pre2010082904 ,1 4.0b5pre2010083104
20100906 10 ,1 4.0b5pre2010083104 ,1 4.0b6pre2010090604 ,6 4.0b52010083108 
20100907 125 ,1 4.0b4pre2010081404 ,2 4.0b5pre2010083104 ,118 4.0b52010083108 
20100908 555 ,2 4.0b6pre2010090604 ,552 4.0b52010083108 ,1 4.0b6pre2010090304
20100909 589 ,2 4.0b6pre2010090904 ,586 4.0b52010083108 ,1 4.0b6pre2010090804
20100910 653 ,3 4.0b6pre2010091004 ,2 4.0b5pre2010083104 ,646 4.0b52010083108 
20100911 647 ,1 4.0b5pre2010082804 ,646 4.0b52010083108
20100912 535 ,1 4.0b6pre2010091104 ,1 4.0b6pre2010091204 ,533 4.0b52010083108

bas indicates that it might be mitigated on the trunk and in b6 with some changes going on there.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: firefox post-driverupdate screenshot

Well, I just reinstalled my video drivers while the latest trunk nightly was running.

It didn't crash, but it looked like this until I restarted Firefox.

Comment 5

[Bas Schouten (:bas.schouten)]

(In reply to comment #4)
> Created attachment 474814 [details]
> firefox post-driverupdate screenshot
> 
> Well, I just reinstalled my video drivers while the latest trunk nightly was
> running.
> 
> It didn't crash, but it looked like this until I restarted Firefox.

That's what I'd expect! I'm currently working on a fix for this problem.

Comment 6

[Scoobidiver (away)]

It still crashes in trunk builds after a graphic driver update.

See the 4 comments in the following reports :
http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A4.0b7pre&query_search=signature&query_type=exact&query=cairo_d2d_present_backbuffer&date=09%2F21%2F2010%2001%3A25%3A29&range_value=1&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=cairo_d2d_present_backbuffer

Comment 7

[JK]

It also happens when the display driver crashes and resets.

http://crash-stats.mozilla.com/report/index/bp-8bc1d742-c0f2-46cc-86af-3b6522100924

Comment 8

[Bas Schouten (:bas.schouten)]

This codepath is going away with accelerated layers. Eventually it should probably be nuked completely.

Comment 9

[JK]

It crashes with D3D9 layers, but not with D3D10.

http://crash-stats.mozilla.com/report/index/bp-c022a360-dc2a-4547-ac69-ababe2101022

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I just did a driver update while Firefox nightly was running (with accelerated layers). 

Firefox successfully survived the update, displaying everything just fine (my card lets me use D2D/D3D10, if that matters). 

Only issue it seemed to have was the window not remembering its previous dimensions, defaulting back to 640x800 or something. (I'm not sure if that's the responsibility of the application or the OS to handle...)

Marking WORKSFORME, unless anyone has any complaints.

(In reply to comment #8)
> This codepath is going away with accelerated layers. Eventually it should
> probably be nuked completely.

Is this still relevant?