592697 - Remove "Always use my page and link colors" from prefs

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Stuart Morgan]

We've had a number of bugs that turned out to be people setting this pref without actually understanding what it really does, and apparently not connecting the fact that everything looks broken with the pref they changed.

The reality of the web is that a lot of sites will be horribly broken with this pref set, so it's probably doing more harm than good overall. Those who really need it can use about:config, and we can document it (with bold warnings) on our hidden prefs page.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When we do this, we need to make sure we change the resizing code to key off of "Underline links" instead; iirc it currently keys off of "Always use my page and link colors".

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This happened again (bug 624190).  I need to get a flag up for b1, but I think this blocks that.

Comment 3

[Stuart Morgan]

Attachment: New nib

New nib. This is saved on 10.6, so IB did the classes.nib/info.nib -> designable.nib change. I don't know if we care; if so it'll need resaving in an older IB.

While I was in there I swapped the tab order, since it's weird to have the more useful, default-selected tab be the second one. (I was tempted to remove the whole colors tab entirely, but I figured someone would object...)

Comment 4

[Stuart Morgan]

Attachment: Code changes

Removes the dead outlet and pref, and adjusts the auto-sizing.

Comment 5

[Stuart Morgan]

We need to remember to add documentation to the hidden prefs page when this lands.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: New nib, resaved to be IB2-compatible

(In reply to comment #3)
> New nib. This is saved on 10.6, so IB did the classes.nib/info.nib ->
> designable.nib change. I don't know if we care; if so it'll need resaving in an
> older IB.

I decided I cared about that, so this is resaved on 10.5 as an IB2-compatible .nib.  At some point we'll need to bite the bullet, but for now let's hold the line about some nibs one way and some nibs the other.

> While I was in there I swapped the tab order, since it's weird to have the more
> useful, default-selected tab be the second one. (I was tempted to remove the
> whole colors tab entirely, but I figured someone would object...)

Out of scope for this bug, at least ;)

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 504357 [details]
New nib

Looks and works as expected, forwards and backwards, r=ardissone (but let's use the resaved version).

Comment 8

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/e459c0f5adcf with the resaved nib.