592750 - kill_process_by_name should be made sane or just kill it

Status: RESOLVED WORKSFORME

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

kill_process_by_name is a completely insane function, and its written in an insane way:

http://github.com/mozautomation/mozmill/blob/master/mozrunner/mozrunner/__init__.py#L115

Firstly, you'll notice that you're effectively doing 

kill `ps ax | grep '${NAME}' | awk '{print $1}'`

This is pretty bad :( For instance, if ${NAME} == 'crashreporter' and I'm running `emacs -nw crashreporter.txt` then I just killed my emacs.  

The function is also internally insane.

The function is also only used in one place:

http://github.com/mozautomation/mozmill/blob/master/mozrunner/mozrunner/__init__.py#L469

The function is also overloaded for windows and called from the master function.

Overall, this is a lot of code for one usage case that is hard to read and buggy.

Comment 1

[Jeff Hammel]

See also bug 616383

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I still don't see a reason why this should be confidential. Can you please enlighten (at least) me?

Comment 3

[Jeff Hammel]

(In reply to comment #2)
> I still don't see a reason why this should be confidential. Can you please
> enlighten (at least) me?

Oops, shouldn't be.  Must have mis-clicked

Comment 4

[Jeff Hammel]

its dead now, see bug 616383