592773 - Refresh list of Tabs from other computers fails after closing a Tab from other computer

Status: RESOLVED WONTFIX

(Firefox :: Sync, defect, P4)

Description

[Tracy Walker [:tracy]]

Seen on Fx4beta5 build 1 on Mac 1o.6 and Win XP

STR:

0) ensure you have synced tabs from other computers

1) Click main Menu History > Tabs From Other Computers
2) Double Click on one of the listed tabs
3) Switch Back to the Tabs from Other Computers tab.
4) Close the tab you opened in step 2.
5) Context click in Tabs from Other Computers tab 
6) Select Refresh List

Tested results:
Tab's from other computers page is not updated

Expected results:
after step 6, the Tab should again be listed under the computer it was synced from.

Comment 1

[Philipp von Weitershausen [:philikon]]

Not a new bug on 4.0b5, removing regression flag.

Comment 2

[Tracy Walker [:tracy]]

Here is some additional bizarreness:

do steps 1-6 above, then do:

7) wait 15 seconds, then
8) Context click in Tabs from Other Computers tab 
9) Select Refresh List

In this case, the page correctly refreshes from the context menu.

Comment 3

[Philipp von Weitershausen [:philikon]]

That means we're hitting the sessionstore refresh interval (15 secs by default). What happens if you change the 'browser.sessionstore.interval' pref to, say, 5000. Does the tab re-appear already after 5 secs?

Comment 4

[Tracy Walker [:tracy]]

hmmm, I get varying results changing that config setting.  But I think that's it.  

However, shortening the interval does allow the refresh list to work sooner.  Lengthening the interval delays it working (though not always for a much as I set it the interval to?)

Comment 5

[Philipp von Weitershausen [:philikon]]

Yes, the interval determines the maximum wait you will experience. It could refresh sooner.

So the problem is that TabEngine.locallyOpenTabMatchesURL() uses TabStore.getAllTabs() which uses nsISessionStore.getBrowserState(). Apparently its return value can be stale up to the amount of that interval.

The current algorithm seems a bit inefficient anyway (it does the above for every single remote tab). I wonder if we couldn't simply walk through the windows and their tabs and collect all open URIs and then just match on containment in that list.

Comment 6

[Richard Newman [:rnewman]]

Flagging this to be addressed this time around.

Comment 7

[Chris Karlof [:ckarlof]]

about:sync-tabs has been deprecated. Better synced tabs UI has been implemented in a menu panel (bug 1201331) and sidebar (bug 1210586).