Closed Bug 592785 Opened 14 years ago Closed 14 years ago

Don't report add-ons as incompatible if they are already incompatible with the current version

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(2 files)

patch rev1
2.29 KB, patch
mossop
: review+
mossop
: approval2.0+
Details | Diff | Splinter Review
patch - comment addressed - ready for checkin
2.28 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch rev1 — — Splinter Review 
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

        Attachment #471205 -
        Flags: review?(dtownsend)

        Attachment #471205 -
        Attachment is patch: true

        Attachment #471205 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  
Comment on attachment 471205 [details] [diff] [review]
patch rev1

Should be able to simplify those to just addon.isCompatible

        Attachment #471205 -
        Flags: review?(dtownsend) → review+

        Attachment #471205 -
        Flags: approval2.0+

    
    

    
  
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/1d82f70c5239

minusing in-testsuite and in-litmus since this is a fix for an edgecase where the user has added the hidden checkCompatibility.x.x preference
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: