592801 - IndexedDB: IDBRequest rework, make everything an event target

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This makes everything an event listener, removes abort from IDBRequest, and simplifies event target creation.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/bb3b8e8f2b79

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Now that more things are cycle collected some threadsafety assertion (that I've still never been able to reproduce) is causing aborts. Pushed this to bulletproof everything. Hopefully it will stick.

http://hg.mozilla.org/mozilla-central/rev/c9f69a3d43af

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #3)
> http://hg.mozilla.org/mozilla-central/rev/c9f69a3d43af

I meant http://hg.mozilla.org/mozilla-central/rev/6c0203305272

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Backout patch, just in case

Just in case (everything looks fine so far) here is a patch to back out this patch without needing to backout the others it landed with (UI for beta 6). Hoping this can just sit here.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 473974 [details] [diff] [review]
Backout patch, just in case

Looks like this won't be necessary after all!