592866 - union in rpc method code generation seems wrong...

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Oleg Romashin (:romaxa)]

add in PPluginInstance.ipdl:

using mozilla::null_t;

union MaybeShmem {
  null_t;
  Shmem;
};
rpc Flush(NPRect rect, Shmem backMem) returns (MaybeShmem rtnbuffer);


and you get compilation error, like 

./../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h:154: error: invalid initialization of reference of type 'mozilla::ipc::Shmem&' from expression of type 'const mozilla::ipc::Shmem'
In file included from ../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstanceParent.h:9,
                 from PBrowserStreamParent.cpp:9:
../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h: In member function 'mozilla::ipc::Shmem& mozilla::plugins::MaybeShmem::get_Shmem() const':
../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h:154: error: invalid initialization of reference of type 'mozilla::ipc::Shmem&' from expression of type 'const mozilla::ipc::Shmem'
In file included from ../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstanceParent.h:9,
                 from PPluginStreamParent.cpp:9:
../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h: In member function 'mozilla::ipc::Shmem& mozilla::plugins::MaybeShmem::get_Shmem() const':

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Allow Shmem to be used in IPDL unions

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 471309 [details] [diff] [review]
Allow Shmem to be used in IPDL unions

Seems ok to me.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Allow Shmem to be used in IPDL unions, v2

Fixed a minor twiddly bug, no need for re-review.

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 471327 [details] [diff] [review]
Allow Shmem to be used in IPDL unions, v2

this seems to work fine.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/ed4a1318e3e9