592908 - Update the text "organize bookmarks" in the Firefox menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

New text should be "Show All Bookmarks" since some may be held in unsorted, and for balance with the "Show All History" at the top of the history menu.

We will need to use a new entity so that localizers realize that we've made the change.  This text is also being used over in bug 592900

Comment 1

[Alex Limi (:limi) — Firefox UX Team]

Not to pile on here, but a +1 for very large values of 1. ;)

I see people struggle to find the "all" word, nobody is scanning for the word "organize" — and making it consistent with the wording in the History menu makes perfect sense.

Comment 2

[u88484]

(In reply to comment #1)
> Not to pile on here, but a +1 for very large values of 1. ;)
> 
huh?

Comment 3

[u88484]

Attachment: Patch v1

Changes Firefox menu's "Organize Bookmarks" to "Show All Bookmarks"

I also updated the Menu bar's Bookmarks -> "Organize Bookmarks" to be "Show All Bookmarks".  I did this for consistency sake and I seen another bug earlier today with an ascii mockup showing that menu entry to also be "Show All Bookmarks" so I figured I'd just change it now instead of having to add a new string then later remove that string.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 471627 [details] [diff] [review]
Patch v1

>-      <menuseparator id="organizeBookmarksSeparator"/>
>+      <menuseparator id="showAllBookmarksSeparator"/>

Avoid this change, add-ons are using this id.

Comment 5

[u88484]

Attachment: Patch v2 for checkin

(In reply to comment #4)
> Comment on attachment 471627 [details] [diff] [review]
> Patch v1
> 
> >-      <menuseparator id="organizeBookmarksSeparator"/>
> >+      <menuseparator id="showAllBookmarksSeparator"/>
> 
> Avoid this change, add-ons are using this id.
Reverted that change.

Carrying review over and requesting approval2.0?

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3674fcac8e15

Comment 7

[u88484]

Verified fixed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100905 Firefox/4.0b6pre

Comment 8

[Marcia Knous [:marcia]]

Litmus test case for Menus has been updated - https://litmus.mozilla.org/show_test.cgi?id=10033