Closed Bug 592992 Opened 9 years ago Closed 9 years ago

hoist outerizing from js::Invoke to js::ExternalInvoke

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: luke, Assigned: luke)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Internal callers should not be passing inner windows as 'this' to js::Invoke.  However, API callers may do so, so the check is needed.  Fortunately, all such API callers are already funneling through ExternalInvoke, so we can hoist the check there.
Attachment #471452 - Flags: review?(mrbkap)
No longer blocks: 539144
Depends on: 580128
Attached patch patchSplinter Review
Attachment #471452 - Attachment is obsolete: true
Attachment #487461 - Flags: review?(mrbkap)
Attachment #471452 - Flags: review?(mrbkap)
With bug 580128 landed, green on try.
Attachment #487461 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/tracemonkey/rev/6ecdb8a8a495
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/6ecdb8a8a495
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.