Closed
Bug 592992
Opened 14 years ago
Closed 14 years ago
hoist outerizing from js::Invoke to js::ExternalInvoke
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
3.36 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Internal callers should not be passing inner windows as 'this' to js::Invoke. However, API callers may do so, so the check is needed. Fortunately, all such API callers are already funneling through ExternalInvoke, so we can hoist the check there.
Attachment #471452 -
Flags: review?(mrbkap)
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #471452 -
Attachment is obsolete: true
Attachment #487461 -
Flags: review?(mrbkap)
Attachment #471452 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 2•14 years ago
|
||
With bug 580128 landed, green on try.
|
||
Updated•14 years ago
|
Attachment #487461 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/6ecdb8a8a495
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6ecdb8a8a495
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•