Use -fomit-frame-pointer when compiling jsinterp.c

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 months ago

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
js/src/Makefile.in explicitly sets the flags for jsinterp.c to

  -O3 -fstrict-aliasing

when using GCC.  But the MODULE_OPTIMIZE_FLAGS are set to

  -O3 -fstrict-aliasing -fomit-frame-pointer $(MOZ_OPTIMIZE_SIZE_TWEAK),

which seems much better.
(Assignee)

Comment 1

8 years ago
I may fix this in Bug 592923, unless there are objections.
(Assignee)

Comment 2

8 years ago
Fix up in bug 592923.
(Assignee)

Comment 3

8 years ago
Created attachment 474140 [details] [diff] [review]
Patch v1

Here's the stand-alone patch for this that I probably should have written in the first place.
Attachment #474140 - Flags: review?(ted.mielczarek)

Comment 4

8 years ago
dvander measured and said this *might* be a 1-2% win on V8.
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> What does "might" mean?

Probably that there's too much variance to really tell.

I'm pushing to try now.

Comment 7

8 years ago
(In reply to comment #5)
> What does "might" mean?

Statistical significance.
(Assignee)

Comment 8

8 years ago
I'm happy to land this if we get approval.
Comment on attachment 474140 [details] [diff] [review]
Patch v1

I think I ignored this because you had it patched elsewhere, but this is good.
Attachment #474140 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → justin.lebar+bug
(Assignee)

Updated

8 years ago
Attachment #474140 - Flags: approval2.0?
(Assignee)

Comment 10

8 years ago
This looks good on try.

Updated

8 years ago
Attachment #474140 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 11

8 years ago
http://hg.mozilla.org/mozilla-central/rev/19b83a1f22db
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.