js/src/Makefile.in explicitly sets the flags for jsinterp.c to -O3 -fstrict-aliasing when using GCC. But the MODULE_OPTIMIZE_FLAGS are set to -O3 -fstrict-aliasing -fomit-frame-pointer $(MOZ_OPTIMIZE_SIZE_TWEAK), which seems much better.
I may fix this in Bug 592923, unless there are objections.
Fix up in bug 592923.
Created attachment 474140 [details] [diff] [review] Patch v1 Here's the stand-alone patch for this that I probably should have written in the first place.
Attachment #474140 - Flags: review?(ted.mielczarek)
dvander measured and said this *might* be a 1-2% win on V8.
What does "might" mean?
(In reply to comment #5) > What does "might" mean? Probably that there's too much variance to really tell. I'm pushing to try now.
(In reply to comment #5) > What does "might" mean? Statistical significance.
I'm happy to land this if we get approval.
Comment on attachment 474140 [details] [diff] [review] Patch v1 I think I ignored this because you had it patched elsewhere, but this is good.
Attachment #474140 - Flags: review?(ted.mielczarek) → review+
Attachment #474140 - Flags: approval2.0?
This looks good on try.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.