593133 - TM: PGO doesn't use tracejit profile

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

This is trace-monkey tree issue.  And, maybe, related to Bug 592791.

Now, automation.py that used by PGO and etc (automation test).

http://hg.mozilla.org/tracemonkey/file/391c5c261186/build/automation.py.in

   348 user_pref("javascript.options.jit.content", false); <-- typo of tracejit.content?
   349 user_pref("javascript.options.methodjit.content", true);

So, tracejit is tuned off now.  At least, we should fix this typo even if tracejit is turned off on PGO.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 472339 [details] [diff] [review]
fix

David, should we keep disable tracejit on automation.py?  It is used on PGO profiling.

Also, "javascript.options.jit.content" is invalid on TM+JM.  You changed name to "javascript.options.tracejit.content"

Comment 3

[David Mandelin [:dmandelin]]

Comment on attachment 472339 [details] [diff] [review]
fix

Yes, this is correct. I kind of remembered there being some extra file(s) to be changed, but for whatever reason, i didn't find them when I looked. Thanks for catching!

Comment 4

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/tracemonkey/rev/cf0c61909787

Comment 5

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/mozilla-central/rev/cf0c61909787