Closed Bug 593133 Opened 9 years ago Closed 9 years ago

TM: PGO doesn't use tracejit profile

Categories

(Core :: JavaScript Engine, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

This is trace-monkey tree issue.  And, maybe, related to Bug 592791.

Now, automation.py that used by PGO and etc (automation test).

http://hg.mozilla.org/tracemonkey/file/391c5c261186/build/automation.py.in

   348 user_pref("javascript.options.jit.content", false); <-- typo of tracejit.content?
   349 user_pref("javascript.options.methodjit.content", true);

So, tracejit is tuned off now.  At least, we should fix this typo even if tracejit is turned off on PGO.
Attached patch fixSplinter Review
Comment on attachment 472339 [details] [diff] [review]
fix

David, should we keep disable tracejit on automation.py?  It is used on PGO profiling.

Also, "javascript.options.jit.content" is invalid on TM+JM.  You changed name to "javascript.options.tracejit.content"
Attachment #472339 - Flags: review?(dmandelin)
Comment on attachment 472339 [details] [diff] [review]
fix

Yes, this is correct. I kind of remembered there being some extra file(s) to be changed, but for whatever reason, i didn't find them when I looked. Thanks for catching!
Attachment #472339 - Flags: review?(dmandelin) → review+
http://hg.mozilla.org/tracemonkey/rev/cf0c61909787
Assignee: general → m_kato
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/cf0c61909787
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.