593228 - Add argument for strict warnings output to Reflect API

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, enhancement)

Description

[Alex Vincent [:WeirdAl]]

One nice feature of Komodo Edit is it will highlight JavaScript strict warnings for you.  The Reflect API throws exceptions for syntax errors.  I wonder if we can alter the API to include an optional out array parameter for strict warnings.

Comment 1

[Dave Herman [:dherman]]

This sounds plausibly do-able. I'll dig into jsparse.

At this point it seems there are enough optional arguments (see also 569487) that maybe the API should take an object argument with the optional arguments encoded as properties, in the usual idiom.

Dave

Comment 2

[Dave Herman [:dherman]]

> (see also 569487)

Ahem: bug 569487.

Dave

Comment 3

[Dave Herman [:dherman]]

Now I'm confused. I don't see any mandated warnings in ES5-strict. Did you mean that strict-mode *errors* should be demoted to warnings and parsing should proceed? That might be a little harder, but I'd have to look.

Dave

Comment 4

[Alex Vincent [:WeirdAl]]

(In reply to comment #3)
> Now I'm confused. I don't see any mandated warnings in ES5-strict. Did you mean
> that strict-mode *errors* should be demoted to warnings and parsing should
> proceed? That might be a little harder, but I'd have to look.
> 
> Dave

No, I didn't mean that.  But certain things trigger strict warnings:

function foo() {
  if (bar) {
    var response = true
    } else {
    var response = false
  }
}

Comment 5

[Alex Vincent [:WeirdAl]]

I was starting to think along the lines of a config param, with several options:
* Ignore strict warnings (default)
* Treat strict warnings as errors (throw whenever you encounter either of them)
* Throw on errors first, and if none, throw for the first strict warnings (prioritize errors over warnings)
* Return strict warnings as a JS array, if any are present (throw for exceptions, but track and report strict warnings separately)