Closed Bug 593328 Opened 9 years ago Closed 9 years ago

Only build hudservice for Firefox

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b7

People

(Reporter: kairo, Assigned: kairo)

References

Details

(Whiteboard: [kd4b7])

Attachments

(1 file)

As the Web Console is currently implemented in Firefox-specific ways, it's best if it's just not built for other applications.

I understand that going for bug 579909 fully and moving to browser/ is probably not in the cards in the rush to get a FF4 release stabilized, so just adding an ifdef to only build the service and tests for FF is probably the easiest thing. Having the theme files around in the JARs is not a problem, but e.g. having the tests run for other products or possibly add-ons wrongly believing they can hook into the Web Console is not what we should have in apps that can't support this.

I have an easy ifdef patch around, will attach in a minute.
And here's the easy ifdef patch. In theory, I could test for MOZ_PHOENIX instead, but some time ago, I have heard that testing for MOZ_BUILD_APP is preferred. Still, I'll leave that up to review.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #471816 - Flags: review?(sdwilsh)
Severity: normal → blocker
Whiteboard: [kd4b7]
Reprioritizing bugs. You can filter the mail on the word TEABAGS.
Severity: blocker → normal
Comment on attachment 471816 [details] [diff] [review]
just ifdef it FF-only

I'm going to delegate this to ted since he'll be able to answer comment 1 better than I.
Attachment #471816 - Flags: review?(sdwilsh) → review?(ted.mielczarek)
Blocks: devtools924
Comment on attachment 471816 [details] [diff] [review]
just ifdef it FF-only

Stealing.
Attachment #471816 - Flags: review?(ted.mielczarek) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/2779c55431a4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Attachment #471816 - Flags: approval2.0?
Attachment #471816 - Flags: approval2.0?
This broke "firefox on top of xulrunner" builds as toolkit is part of xulrunner but is not built as browser.
I opened bug 601907 as a followup to this to look into the Firefox on xulrunner problem.
Oops, sorry, I discussed with khuey already and filed 601890 (forgot to mention here)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.