Closed Bug 593357 Opened 11 years ago Closed 11 years ago

Stop/Go/Reload button breaks resizing the location and search bar after it was relocated and reattached back to the location bar

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: Ryuji, Assigned: fryn)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre

Now it is impossible to resize either the Location bar or the search bar.

Reproducible: Always
Summary: New attached Stop/Go/Refresh button breaks resizing the location and search bar → Newly attached Stop/Go/Refresh button breaks resizing the location and search bar
Blocks: 544816
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre

Works for me
Well it don't break if you don't do something to it. 

STR: 
1. Open Firefox with some Tabs
2. Go to Customize. 
3. Relocated the Reload & Stop button back to the left, next to the Home Button.
4. Press Done
5. It recombine to become the Reload/Stop button
6. Go to Customize again
7. Relocated the Reload & Stop button back to the right of the location bar and the left of the search bar. 
8. Press Done and You see that the Reload/Stop/Go button is back. 
9. Now go and try to resize the location bar and the search bar. 
10. You will realise that it is now not possible to do so. 
11. to solve this go to customize again and press done. 
12. Problem Solved. 

But it remain a problem if it break resizing after relocating and reattaching it back to the location bar.
Summary: Newly attached Stop/Go/Refresh button breaks resizing the location and search bar → Stop/Go/Reload button breaks resizing the location and search bar after it was relocated and reattached back to the location bar
Mozilla/5.0 (X11; Linux i686; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre

Confirmed using STR in comment 2.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee: nobody → fryn
Status: NEW → ASSIGNED
blocking2.0: --- → ?
Attached patch patchSplinter Review
simply moved splitter update code after combined location bar code.
Attachment #486820 - Flags: review?(dolske)
How are the two interacting?
(In reply to comment #5)
> How are the two interacting?

The splitter update code checks to the combined attribute of the location bar as part of the logic to determine whether a splitter should be inserted.
The combined attribute is set by the combined stop/reload code.
Comment on attachment 486820 [details] [diff] [review]
patch

Perhaps worth a comment?
Attachment #486820 - Flags: review?(dolske)
Attachment #486820 - Flags: review+
Attachment #486820 - Flags: approval2.0+
Don't think this blocks, but we'll take the patch.
blocking2.0: ? → -
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #7)
> Comment on attachment 486820 [details] [diff] [review]
> patch
> 
> Perhaps worth a comment?

Pushed with explanatory comment. Thanks.
You need to log in before you can comment on or make changes to this bug.