593377 - bug 535922 killed all tests in dom/tests/browser

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Bug 535922's patch killed all tests in dom/tests/browser. I'll post the patch, but unfortunately, we miss-catch a regression by this regression.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

I'll request a review after I confirm that all tests pass on tryserver.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Um... We had the same issue with the docshell tests from the same patch too.  Was the patch not audited for similar problems after that?  Are there any other parts of our test suite it conveniently disabled?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #2)
> Um... We had the same issue with the docshell tests from the same patch too. 
> Was the patch not audited for similar problems after that?  Are there any other
> parts of our test suite it conveniently disabled?

I'm not sure, I found this bug when I tried to add a new test for bug 591890.

Doesn't the docshell work fine too? Looks like docshell folder is in _tests/testing/mochitest/browser.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 471858 [details] [diff] [review]
Patch v1.0

passed on Mac and Linux.

Boris, would you review this?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 471858 [details] [diff] [review]
Patch v1.0

r=me

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you, I'll land it tomorrow morning.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/a9a1bbd4176f