593416 - Bug 544816 landing breaks testGoButtonOnTypeOnly

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Steve Scott (pxbugz)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre

Go button is now part of urlbar

Reproducible: Always

Comment 1

[Steve Scott (pxbugz)]

Attachment: Change to call url-go-button

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Steve! For the future please also add the information below in the initial comment:

MODULE: firefox/testAwesomeBar/testGoButton.js
TEST:   testGoButtonOnTypeOnly
FAIL:   controller.assertJS: Failed for 'subject.visible == subject.expectedVisibility'
BRANCH: trunk

Comment 3

[Frank Yan (:fryn)]

(In reply to comment #1)
> Created attachment 471914 [details] [diff] [review]
> Change to call url-go-button

indentation nit:

       case "goButton":
-        elem = new elementslib.ID(this._controller.window.document, "go-button");
+		elem = new elementslib.ID(controller.window.document, "urlbar-go-button")

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 471914 [details] [diff] [review]
Change to call url-go-button

>diff --git a/shared-modules/testToolbarAPI.js b/shared-modules/testToolbarAPI.js
>-        elem = new elementslib.ID(this._controller.window.document, "go-button");
>+		elem = new elementslib.ID(controller.window.document, "urlbar-go-button")

controller doesn't exist in the API. It's probably a c&p failure from your testing. Check the line above how it has to look like. Also please remove the tab characters at the beginning of the line and replace it with spaces. And a final semicolon would be nice too. Otherwise good find!

Comment 5

[Steve Scott (pxbugz)]

Attachment: Updated patch from comments

Comment 6

[Steve Scott (pxbugz)]

Attachment: Updated with the right patch

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 471956 [details] [diff] [review]
Updated with the right patch

Will check tomorrow. Thanks for the updated patch.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/47ba3ed824d8

Thanks again! Good to see that you were able to catch up so fast.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.