593455 - Pinned Tab notifications are lost on return from Private Browsing session

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre

Presently, when application tabs are in their state of notification (as of 09/03 they are red) and a user enters and exits PB mode, notifications are lost when the browser returns to normal browsing. 

These notifications should not be lost as a result of a PB mode session.

STR:

1. Load testscript in a tab, and open a second tab
2. Make first tab with testscript an Application Tab
3. Click the button, and switch to the second tab
4. Enter PB mode
5. Exit PB mode

Notice the notification has been removed from the Application Tab

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Testcase

Comment 2

[(no longer active)]

I have a strong feeling that this happens because of a bug in sessionstore's setBrowserState.  CCing zpao to see if he has any ideas.

Comment 3

[(no longer active)]

Note to self: the notification was added in http://hg.mozilla.org/mozilla-central/rev/a9648cc0b2c6

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #2)
> I have a strong feeling that this happens because of a bug in sessionstore's
> setBrowserState.  CCing zpao to see if he has any ideas.

Indeed, though not so much a bug as a feature request :)

Bug 577096 added the titlechanged attribute to tabs (whose title has changed, surprise), so we just need to make sure we store that.

I'm going to assume we only want that restored within a session and not across sessions (since the title hasn't really changed then). That makes it ever so slightly more complicated, but I'm already doing that in my patch in bug 588482 so that's not a big deal

Comment 5

[Aaron Train [:aaronmt]]

Feel free to update the summary or morph this bug to reflect the session store

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Annoying, but not blocking.

Comment 7

[Dão Gottwald [:dao]]

Private browsing mode doesn't exist anymore, we have private windows now instead.