593504 - Need to namespace variables in utils and init and add help link

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[cmtalbert]

From AMO review:
The following files of MozMill 1.5.0 have been made public by a Mozilla Add-ons editor:

MozMill 1.5.0 - ALL

Review Information:
Reviewer: Jorge Villalobos
Tested on Mac OS X with Firefox
Comments: Your update has been approved. Thanks!

Please add some namespacing to variables utils and init in the main overlay. They could conflict with variables in the browser or other add-ons.

I also think it would be a good idea to include a Help link or something similar in the UI, pointing to documentation on how to create and run tests.

If you have questions about this review, please reply to this email or join #addons on irc.mozilla.org.

Thanks Jorge for the feedback.  Let's do this for 1.5.1.

Comment 1

[Heather Arthur [:harth]]

Attachment: namespace overlay vars and add help link to menu

Namespace variables in jsbridge and mozmill extensions, and adds help link. Right now the help link doesn't have any test writing docs, but Henrik is going to fix that.

Comment 2

[cmtalbert]

Comment on attachment 478445 [details] [diff] [review]
namespace overlay vars and add help link to menu

Looks great.  Since we're cleaning up stuff, and we change that overlay.js file to have the standard * style license block too while we're cleaning up everything else.

Comment 3

[Heather Arthur [:harth]]

1.5.1:
http://github.com/mozautomation/mozmill/commit/f6aad248c02b218120078b9eee956303455c3452

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has not been landed on master yet.

Comment 5

[Heather Arthur [:harth]]

yeah, I thought we were going to try to merge 1.5.1 into master after we released off of 1.5.1 as per the workflow.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have sent out an email to the mailing list, because this process has been mixed. Some of the patches have already been landed on master. So lets wait for an answer from Clint over there.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As discussed with Clint, we will have a weekly merge from now on. Lets identify the todo action in the whiteboard.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good. Marking as verified fixed.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on master as:
http://github.com/mozautomation/mozmill/commit/2fd5a0930c26a1005b28baf561a088dcec03a615