59352 - Remove "used only once fix" silliness from globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Johan Vromans]

When "use strict" was added to the bugzilla scripts, there were some
misconceptions about the use of "use vars". Therefore, to avoid warnings, lots
of sillyness was introduced.

The attached patch fixes the sillynesses for "globals.pl", being one of the two
central files. Patches for the other files will follow in due time.
Note that the fixes for each of the files are independent of each other.

Comment 1

[Johan Vromans]

Attachment: Remove sillyness from globals.pl

Comment 2

[Dave Miller [:justdave]]

moving to real milestones...

Comment 3

[Andreas Franke (gone)]

-> Bugzilla product, General component, reassigning.

Comment 4

[Gervase Markham [:gerv]]

jvromans: Cool :-) Can you explain exactly what the problem was? We have
sillyness everywhere, and it would be great to get rid of it.

Gerv

Comment 5

[Gervase Markham [:gerv]]

jvromans: your patches have probably rotted, but they can be recreated if you
explain what we did wrong! :-)

Gerv

Comment 6

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 7

[Jouni Heikniemi]

This would be really cool, those sillynesses suck. [e-mail], ping?

Can somebody explain what the comment 'For some reason, "use vars" chokes on me
when I try it here.' actually meant? How did it choke? The cvs commit log entry
for the revision containing those lines doesn't have a bug number nor a decent
description...

Comment 8

[Andreas Franke (gone)]

I think the problem was the original code author didn't know the correct syntax
for using "use vars". Someone pointed out the correct usage in some bug, so
recent code uses the correct syntax, hence the issue at hand is to update the
remaining files which still use sillyness to the syntax used everywhere else.

Comment 9

[Gervase Markham [:gerv]]

globals.pl will go away eventually, so it's probably not worth doing this. It
doesn't hurt anyone.

Patches for CGIs which are sticking around, on the other hand, are most welcome :-)

Gerv

Comment 10

[Dave Miller [:justdave]]

All 2.18 bugs that haven't been touched in over 60 days and aren't flagged as
blockers are getting pushed out to 2.20

Comment 11

[Frédéric Buclin]

Fixed by bug 328637