593558 - [OpenGL] Reftest fails because of too much output printed to console

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

See: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283581072.1283583594.5920.gz&fulltext=1

The easy solution would be to remove the printf_debug calls from GLContext::InitExtensions.

However I can't see how these would differ on a per context basis, so I think we should try make these checks run only once, and then leave the debug spew.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Fix v1

Make the extension availability data static, so we only need to check it once.

This is relying on the data not changing per context.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 472126 [details] [diff] [review]
Fix v1

Nope, we can have multiple types of contexts active at once, so this can't be static.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: print extensions only once

But we can do something like this, which just prints for the first context which is usually the only info that's needed.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 472180 [details] [diff] [review]
print extensions only once

Works for me!

Comment 5

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/mozilla-central/rev/be2972c2b236