Closed
Bug 593558
Opened 14 years ago
Closed 14 years ago
[OpenGL] Reftest fails because of too much output printed to console
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: mattwoodrow, Assigned: vlad)
References
Details
Attachments
(2 files)
1.92 KB,
patch
|
vlad
:
review-
|
Details | Diff | Splinter Review |
1.73 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
See: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283581072.1283583594.5920.gz&fulltext=1 The easy solution would be to remove the printf_debug calls from GLContext::InitExtensions. However I can't see how these would differ on a per context basis, so I think we should try make these checks run only once, and then leave the debug spew.
Reporter | ||
Comment 1•14 years ago
|
||
Make the extension availability data static, so we only need to check it once. This is relying on the data not changing per context.
Attachment #472126 -
Flags: review?(vladimir)
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 472126 [details] [diff] [review] Fix v1 Nope, we can have multiple types of contexts active at once, so this can't be static.
Attachment #472126 -
Flags: review?(vladimir) → review-
Assignee | ||
Comment 3•14 years ago
|
||
But we can do something like this, which just prints for the first context which is usually the only info that's needed.
Attachment #472180 -
Flags: review?(matt.woodrow+bugzilla)
Reporter | ||
Comment 4•14 years ago
|
||
Comment on attachment 472180 [details] [diff] [review] print extensions only once Works for me!
Attachment #472180 -
Flags: review?(matt.woodrow+bugzilla) → review+
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → beta6+
Reporter | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/be2972c2b236
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Assignee: nobody → vladimir
You need to log in
before you can comment on or make changes to this bug.
Description
•