Closed Bug 593558 Opened 10 years ago Closed 10 years ago

[OpenGL] Reftest fails because of too much output printed to console

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: mattwoodrow, Assigned: vlad)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

See: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283581072.1283583594.5920.gz&fulltext=1

The easy solution would be to remove the printf_debug calls from GLContext::InitExtensions.

However I can't see how these would differ on a per context basis, so I think we should try make these checks run only once, and then leave the debug spew.
Attached patch Fix v1Splinter Review
Make the extension availability data static, so we only need to check it once.

This is relying on the data not changing per context.
Attachment #472126 - Flags: review?(vladimir)
Blocks: 586464
Comment on attachment 472126 [details] [diff] [review]
Fix v1

Nope, we can have multiple types of contexts active at once, so this can't be static.
Attachment #472126 - Flags: review?(vladimir) → review-
But we can do something like this, which just prints for the first context which is usually the only info that's needed.
Attachment #472180 - Flags: review?(matt.woodrow+bugzilla)
Comment on attachment 472180 [details] [diff] [review]
print extensions only once

Works for me!
Attachment #472180 - Flags: review?(matt.woodrow+bugzilla) → review+
blocking2.0: --- → beta6+
http://hg.mozilla.org/mozilla-central/rev/be2972c2b236
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → vladimir
You need to log in before you can comment on or make changes to this bug.