Closed Bug 593569 Opened 14 years ago Closed 14 years ago

New style tabs on linux have gaps occasionally

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b7

People

(Reporter: Swatinem, Assigned: dao)

References

Details

Attachments

(2 files)

screenshot
4.94 KB, image/png
Details
repeat the middle part
1.82 KB, patch
Gavin
: review+
Gavin
: approval2.0+
Details | Diff | Splinter Review
Attached image screenshot — 
Depending on the number of tabs open (the size of each tab), some tabs may have a 1px gap between the close button and the tab border, see screenshot attached.
Attachment #472134 - Attachment is patch: false
Attachment #472134 - Attachment mime type: text/plain → image/png
Depends on: 422179
Note that I scaled the screenshot in gimp myself, I don’t think this depends on any scaling related bug.
Markus suggests it may depend on a border-image issue.
I tested the patches in bug 422179, they fixed it.
... which also explains why we don't see this bug on Windows.
Using repeat instead of stretch for the border image might also fix it (and might even be slightly faster).
(In reply to comment #4)
> Using repeat instead of stretch for the border image might also fix it (and
> might even be slightly faster).

Yep, it does.
Wouldn't hurt to get this in for beta 6, since bug 422179 apparently won't make it.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #473562 - Flags: review?(gavin.sharp)
Attachment #473562 - Flags: review?(gavin.sharp) → review+
Attachment #473562 - Flags: approval2.0?
Attachment #473562 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/cc65070df5cd
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: