593569 - New style tabs on linux have gaps occasionally

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: screenshot

Depending on the number of tabs open (the size of each tab), some tabs may have a 1px gap between the close button and the tab border, see screenshot attached.

Comment 1

[Arpad Borsos [:Swatinem]]

Note that I scaled the screenshot in gimp myself, I don’t think this depends on any scaling related bug.
Markus suggests it may depend on a border-image issue.

Comment 2

[Dão Gottwald [:dao]]

I tested the patches in bug 422179, they fixed it.

Comment 3

[Dão Gottwald [:dao]]

... which also explains why we don't see this bug on Windows.

Comment 4

[Markus Stange [:mstange]]

Using repeat instead of stretch for the border image might also fix it (and might even be slightly faster).

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Using repeat instead of stretch for the border image might also fix it (and
> might even be slightly faster).

Yep, it does.

Comment 6

[Dão Gottwald [:dao]]

Attachment: repeat the middle part

Wouldn't hurt to get this in for beta 6, since bug 422179 apparently won't make it.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/cc65070df5cd