Put tabs on top by default on Linux

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 -)

Details

Attachments

(3 attachments)

We'll need to check with a hopefully representative range of Gtk themes whether tabs on top looks good enough to be the default state. The primary concern I have is that the menu bar is visually separated from the other toolbars and that the tabs would butt against this border, creating an uneasy appearance.
Hardware: x86_64 → All
Dragging a tab button onto the personal tabs bar is less easy to me with tabs on top
Thanks!
(In reply to comment #4)
> Thanks!

If you need more tell me.
Posted image on KDE 4.4
I can't quite compare to the brilliant array posted by Yan, but here's a screenshot of tabs on top on KDE 4.4 with the default Oxygen theme and QtCurve for used for GTK. It looks great, as do all the others posted above.
(In reply to comment #0)
> The primary concern I
> have is that the menu bar is visually separated from the other toolbars and
> that the tabs would butt against this border, creating an uneasy appearance.

Some themes seem to do this on purpose and others don't. Even when they do, it doesn't look bad if that's what the theme was going for.

Everything I've seen thus far looks good and cross-platform consistency would be very good. I say flip the switch please. ;)
Posted patch patchSplinter Review
Attachment #474676 - Flags: review?(gavin.sharp)
Comment on attachment 474676 [details] [diff] [review]
patch

get ui-review?
Attachment #474676 - Flags: review?(gavin.sharp) → review+
Attachment #474676 - Flags: ui-review?(shorlander)
Comment on attachment 474676 [details] [diff] [review]
patch

The inability to extend the menu bar color behind the tabs isn't ideal. It works really well in most cases though.
Attachment #474676 - Flags: ui-review?(shorlander) → ui-review+
Attachment #474676 - Flags: approval2.0?
Summary: Investigate putting tabs on top by default on Linux → Put tabs on top by default on Linux
Keywords: helpwanted
Requesting blocking beta7+ just to make sure this is on the radar, as a lot of Linux users have been complaining about the delay for this.
blocking2.0: --- → ?
It doesn't block beta 7, and I don't think it blocks final either. I'll get the approval request evaluated.
blocking2.0: ? → -
Regardless of blocking then, is this on track for approval2.0+ before beta 7?
Status? Shouldn't this at least be able to land on Trunk for beta 8?
Comment on attachment 474676 [details] [diff] [review]
patch

a=beltzner, can go for beta7
Attachment #474676 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/b4e2b4ad8a5d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.