593850 - fix a bunch of failing webgl tests

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

There's a bunch of webgl tests that are failing for simple reasons.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix gl-object-get test

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix gl-scissor test

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix gl-uniform-arrays test

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix null-uniform-location

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix a few tests by removing debugcontext

this is already checked in upstream; these tests shouldn't be referencing debugcontext.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix bad-args and null-args tests

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 472435 [details] [diff] [review]
fix gl-scissor test

Note: need to send these changes upstream or they will be lost the next time we sync.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 472439 [details] [diff] [review]
fix bad-args and null-args tests

 NS_IMETHODIMP
 WebGLContext::LinkProgram(nsIWebGLProgram *pobj)
 {
+    if (!pobj)
+        return ErrorInvalidValue("linkProgram");
+
     GLuint progname;
     WebGLProgram *program;
     if (!GetConcreteObjectAndGLName("linkProgram", pobj, &program, &progname))


I don't understand this one. GetConcreteObject and friends already do generate ErrorInvalidValue on null objects (unless &isNull is passed). So why is it needed to add these if(!pobj) checks?

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Also, just "linkProgram" is too elusive an error message. How about "linkProgram: null program passed".

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #7)
> Comment on attachment 472435 [details] [diff] [review]
> fix gl-scissor test
> 
> Note: need to send these changes upstream or they will be lost the next time we
> sync.

Already checked in upstream

(In reply to comment #8)
> Comment on attachment 472439 [details] [diff] [review]
> fix bad-args and null-args tests
> 
>  NS_IMETHODIMP
>  WebGLContext::LinkProgram(nsIWebGLProgram *pobj)
>  {
> +    if (!pobj)
> +        return ErrorInvalidValue("linkProgram");
> +
>      GLuint progname;
>      WebGLProgram *program;
>      if (!GetConcreteObjectAndGLName("linkProgram", pobj, &program, &progname))
> 
> 
> I don't understand this one. GetConcreteObject and friends already do generate
> ErrorInvalidValue on null objects (unless &isNull is passed). So why is it
> needed to add these if(!pobj) checks?

Ah yeah, you're right.. this was added in an earlier version where I thought these were supposed to be no-ops, but I was wrong.  I'll get rid of them.

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

all checked in, with ErrorInvalidValue crap removed.

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 472439 [details] [diff] [review]
fix bad-args and null-args tests

This patch has already landed.