Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Port to SeaMonkey changes to test_contextmenu.html from bug 558072 Allow getting of popup position and size from popupshowing event

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Testing Infrastructure
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.1b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

Bug 558072 introduced a small changed to test_contextmenu.html, this should be ported to SM's version of this test.
We don't use Browser:Stop so using context-stop instead.
Attachment #472495 - Flags: review?(neil)

Comment 1

7 years ago
Is this actually causing a test failure? If it is, does changing line 601 to SimpleText.executeSoon(startTest) help? (I unfortunately don't have an up-to-date build with tests, since my VM is out of disk space.)
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> Is this actually causing a test failure? If it is, does changing line 601 to
> SimpleText.executeSoon(startTest) help? (I unfortunately don't have an
> up-to-date build with tests, since my VM is out of disk space.)

It is to fix a potential issue with the new core code that went in with the changes from bug 558072. I presume Neil Deakin did consider that option.

Comment 3

7 years ago
Comment on attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

OK, so if it's not causing a test failure now, can you put in an isnot test too, referencing this bug, so that when it does start failing then at least we're expecting it (and then maybe we can try my other workaround too)? Thanks.
Attachment #472495 - Flags: review?(neil) → review+
(Assignee)

Comment 4

7 years ago
Comment on attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

Checked in with isnot line:
http://hg.mozilla.org/comm-central/rev/fd03993430e4
Attachment #472495 - Attachment description: Port changes to SM patch v0.1 → Port changes to SM patch v0.1 [Checked in: Comment 4]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
|isnot(false, "Document still loading");| is never going to fail, is it?
You need to log in before you can comment on or make changes to this bug.