Closed Bug 593884 Opened 9 years ago Closed 9 years ago

Port to SeaMonkey changes to test_contextmenu.html from bug 558072 Allow getting of popup position and size from popupshowing event

Categories

(SeaMonkey :: Testing Infrastructure, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b1

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

Bug 558072 introduced a small changed to test_contextmenu.html, this should be ported to SM's version of this test.
We don't use Browser:Stop so using context-stop instead.
Attachment #472495 - Flags: review?(neil)
Is this actually causing a test failure? If it is, does changing line 601 to SimpleText.executeSoon(startTest) help? (I unfortunately don't have an up-to-date build with tests, since my VM is out of disk space.)
(In reply to comment #1)
> Is this actually causing a test failure? If it is, does changing line 601 to
> SimpleText.executeSoon(startTest) help? (I unfortunately don't have an
> up-to-date build with tests, since my VM is out of disk space.)

It is to fix a potential issue with the new core code that went in with the changes from bug 558072. I presume Neil Deakin did consider that option.
Comment on attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

OK, so if it's not causing a test failure now, can you put in an isnot test too, referencing this bug, so that when it does start failing then at least we're expecting it (and then maybe we can try my other workaround too)? Thanks.
Attachment #472495 - Flags: review?(neil) → review+
Comment on attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

Checked in with isnot line:
http://hg.mozilla.org/comm-central/rev/fd03993430e4
Attachment #472495 - Attachment description: Port changes to SM patch v0.1 → Port changes to SM patch v0.1 [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
|isnot(false, "Document still loading");| is never going to fail, is it?
You need to log in before you can comment on or make changes to this bug.