Last Comment Bug 593884 - Port to SeaMonkey changes to test_contextmenu.html from bug 558072 Allow getting of popup position and size from popupshowing event
: Port to SeaMonkey changes to test_contextmenu.html from bug 558072 Allow gett...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Ian Neal
:
Mentors:
Depends on: 558072
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-06 16:16 PDT by Ian Neal
Modified: 2010-09-27 05:12 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Port changes to SM patch v0.1 [Checked in: Comment 4] (837 bytes, patch)
2010-09-06 16:16 PDT, Ian Neal
neil: review+
Details | Diff | Review

Description Ian Neal 2010-09-06 16:16:15 PDT
Created attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

Bug 558072 introduced a small changed to test_contextmenu.html, this should be ported to SM's version of this test.
We don't use Browser:Stop so using context-stop instead.
Comment 1 neil@parkwaycc.co.uk 2010-09-07 01:50:25 PDT
Is this actually causing a test failure? If it is, does changing line 601 to SimpleText.executeSoon(startTest) help? (I unfortunately don't have an up-to-date build with tests, since my VM is out of disk space.)
Comment 2 Ian Neal 2010-09-07 05:05:34 PDT
(In reply to comment #1)
> Is this actually causing a test failure? If it is, does changing line 601 to
> SimpleText.executeSoon(startTest) help? (I unfortunately don't have an
> up-to-date build with tests, since my VM is out of disk space.)

It is to fix a potential issue with the new core code that went in with the changes from bug 558072. I presume Neil Deakin did consider that option.
Comment 3 neil@parkwaycc.co.uk 2010-09-10 04:52:05 PDT
Comment on attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

OK, so if it's not causing a test failure now, can you put in an isnot test too, referencing this bug, so that when it does start failing then at least we're expecting it (and then maybe we can try my other workaround too)? Thanks.
Comment 4 Ian Neal 2010-09-17 15:17:35 PDT
Comment on attachment 472495 [details] [diff] [review]
Port changes to SM patch v0.1 [Checked in: Comment 4]

Checked in with isnot line:
http://hg.mozilla.org/comm-central/rev/fd03993430e4
Comment 5 :Ms2ger 2010-09-27 05:12:11 PDT
|isnot(false, "Document still loading");| is never going to fail, is it?

Note You need to log in before you can comment on or make changes to this bug.