593892 - draw the previous page if the current page is suppressed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

There are some rendering artifacts that happen on page transition that occur because we receive an invalidate of the old page, but when we serve that invalidate we have started drawing the new page while it still has painting suppressed. Unless the invalidate is for the whole page this looks bad because it looks like a piece of the old page has been erased. What makes this problem worse is that if the user clicks a link, it will receive a focus rectangle. This focus rectangle will be removed before we start drawing the new page, but we still draw the old page for a time. The invalidate for this focus removal can easily be one of the "bad invalidates" described above.

I am proposing that if the new page has painting suppressed we continue to draw the old page to fix this.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: fix a test

Comment 3

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/11dde247db37
http://hg.mozilla.org/mozilla-central/rev/d5f25a96f0b1