Closed
Bug 593911
Opened 14 years ago
Closed 14 years ago
Check for dlopen in the libc. .
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: anarchy, Assigned: anarchy)
Details
Attachments
(1 file, 2 obsolete files)
3.83 KB,
patch
|
khuey
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Some systems (eg FreeBSD) provide dlopen via libc, we should ensure we make a full check to ensure we are portable.
Assignee | ||
Updated•14 years ago
|
Attachment #472525 -
Attachment is patch: true
Attachment #472525 -
Attachment mime type: application/octet-stream → text/plain
Attachment #472525 -
Flags: review?(khuey)
Comment on attachment 472525 [details] [diff] [review] fix_libdl_check This is fine as is, but we can make it a bit better. Lets change the variable name from ac_cv_my_have_libdl to ac_cv_have_dlopen and wrap the AC_CHECK_FUNC in an AC_CACHE_VAL. Also, we probably should s/HAVE_LIBDL/HAVE_DLOPEN/, but that can be done in a followup if you prefer.
Attachment #472525 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 2•14 years ago
|
||
AC_CACHE_VAL have not been handled yet, soon as this is done we will repost for review.
Assignee | ||
Updated•14 years ago
|
Attachment #472919 -
Flags: review?(khuey)
Assignee | ||
Comment 3•14 years ago
|
||
This will still give us the cache useage and addresses all other comments :)
Attachment #472919 -
Attachment is obsolete: true
Attachment #473333 -
Flags: review?(khuey)
Attachment #472919 -
Flags: review?(khuey)
Comment on attachment 473333 [details] [diff] [review] fix dlopen check, convert defined to HAVE_DLOPEN V0.2 Much nicer :-)
Attachment #473333 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #473333 -
Flags: approval2.0?
Comment 5•14 years ago
|
||
bsmedberg, according to gavin, you are the appropriate person to look at this approval request.
Updated•14 years ago
|
Attachment #473333 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/51de749bebfb
Updated•14 years ago
|
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Version: unspecified → Trunk
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•