593911 - Check for dlopen in the libc. .

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: fix_libdl_check

Some systems (eg FreeBSD) provide dlopen via libc, we should ensure we make a full check to ensure we are portable.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 472525 [details] [diff] [review]
fix_libdl_check

This is fine as is, but we can make it a bit better.  Lets change the variable name from ac_cv_my_have_libdl to ac_cv_have_dlopen and wrap the AC_CHECK_FUNC in an AC_CACHE_VAL.

Also, we probably should s/HAVE_LIBDL/HAVE_DLOPEN/, but that can be done in a followup if you prefer.

Comment 2

[Jory A. Pratt [:anarchy]]

Attachment: fix dlopen check, convert defined to HAVE_DLOPEN V0.1

AC_CACHE_VAL have not been handled yet, soon as this is done we will repost for review.

Comment 3

[Jory A. Pratt [:anarchy]]

Attachment: fix dlopen check, convert defined to HAVE_DLOPEN V0.2

This will still give us the cache useage and addresses all other comments :)

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 473333 [details] [diff] [review]
fix dlopen check, convert defined to HAVE_DLOPEN V0.2

Much nicer :-)

Comment 5

[Mounir Lamouri (:mounir)]

bsmedberg, according to gavin, you are the appropriate person to look at this approval request.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/51de749bebfb