The default bug view has changed. See this FAQ.

Change Location Selection on intel.com is broken

RESOLVED WORKSFORME

Status

Tech Evangelism Graveyard
English US
RESOLVED WORKSFORME
7 years ago
2 years ago

People

(Reporter: Scoobidiver (away), Unassigned)

Tracking

Details

(URL)

(Reporter)

Description

7 years ago
Build : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100906 Firefox/4.0b6pre

Steps to reproduce :
1. Go to the ref URL
2. Hover the mouse over one of the region

Results :
Nothing is displayed in "select a location and language" pane and in the "Intel worldwide" map

Expected results :
The "select a location and language" pane and the "Intel worldwide" map are modified according to the selected region.

This issue appeared between beta 4 and beta 5.
Hmm, disabling the HTML5 Parser does not help.
Keywords: regressionwindow-wanted
Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c8c886655ea1&tochange=5c5c3bf8dfeb

No parser changes there, but a TM merge....  Will bisect.
Keywords: regressionwindow-wanted
I'd really like to know how this ended up in Parser instead of, say, General, btw.  ;)
Keywords: regressionwindow-wanted

Comment 4

7 years ago
In Error Console:
Error: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them
Source file: http://www.intel.com/sites/js/INTEL.js
Line: 9

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/4192ba38ebee
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100820130619
Fails:
http://hg.mozilla.org/mozilla-central/rev/cbf6e0a17783
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre ID:20100820190548
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4192ba38ebee&tochange=cbf6e0a17783

Comment 5

7 years ago
Regression window of TM build:
Works:
http://hg.mozilla.org/tracemonkey/rev/af8d71b0de3b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100817 Minefield/4.0b4pre ID:20100817043016
Fails:
http://hg.mozilla.org/tracemonkey/rev/27a70c60b48d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100818 Minefield/4.0b4pre ID:20100818065537
Pushlog:
http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=af8d71b0de3b&tochange=27a70c60b48d
Assignee: nobody → general
Component: HTML: Parser → JavaScript Engine
QA Contact: parser → general
Blocks: 514581
The first bad revision is:
changeset:   51092:981c0f32ff15
user:        Jeff Walden <jwalden@mit.edu>
date:        Wed Aug 04 14:39:45 2010 -0700
summary:     Bug 514563 - ES5 strict mode: arguments.caller and arguments.callee poison pills.  r=dmandelin

And indeed, the error console (which I should've checked, doh!) says:

  Error: 'caller', 'callee', and 'arguments' properties may not be accessed on
  strict mode functions or the arguments objects for calls to them
  Source File: http://www.intel.com/sites/js/INTEL.js
  Line: 9

The .js file in question does in fact have "use strict;" at the top, and uses callee all over the place.
Assignee: general → english-us
Component: JavaScript Engine → English US
Product: Core → Tech Evangelism
QA Contact: general → english-us
Version: Trunk → unspecified
I sent intel mail via their contact form; we'll see how it goes.
Keywords: regression, regressionwindow-wanted
Blocks: 514563
No longer blocks: 514581
Summary: No change in display after a selection in a list → Change Location Selection on intel.com is broken
Eek. Moh, any ideas on finding whoever at (or working on contract for) Intel added "use strict"; to the front of that line?

http://www.intel.com/sites/js/INTEL.js

Cc'ing jresig in case he knows of some popular movement to sprinkle "use strict"; at the front of scripts, even if doing so breaks those scripts.

I agree that this must be a TE bug.

/be

Comment 9

7 years ago
I'll investigate right away.

Comment 10

7 years ago
This helped alert our IT folks to this potential problem as "Use Strict" is possibly used in other JavaScript files on our web properties. An effort is underway to scan our source code for all instances of this use.

Many thanks for bringing this to our attention.

- moh
Douglas Crockford's JSLint.com service tells you to add the "use strict" pragma if you choose the "Good Parts" option. Unfortunately, JSLint says there's nothing wrong with code like this:

/*global window */
"use strict";

function someFun() {
    window.alert(arguments.callee);
}

someFun();

Comment 12

7 years ago
Hi Brendan & Boris,

Your suggested fix of removing "use strict"; was pushed as part of today's publishing job on Intel site.

Many thanks for your help.

-moh
(Reporter)

Comment 13

7 years ago
I confirm that it works.
So WFM.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.