593963 - Change Location Selection on intel.com is broken

Status: RESOLVED WORKSFORME

(Tech Evangelism Graveyard :: English US, defect)

Description

[Scoobidiver (away)]

Build : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100906 Firefox/4.0b6pre

Steps to reproduce :
1. Go to the ref URL
2. Hover the mouse over one of the region

Results :
Nothing is displayed in "select a location and language" pane and in the "Intel worldwide" map

Expected results :
The "select a location and language" pane and the "Intel worldwide" map are modified according to the selected region.

This issue appeared between beta 4 and beta 5.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Hmm, disabling the HTML5 Parser does not help.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c8c886655ea1&tochange=5c5c3bf8dfeb

No parser changes there, but a TM merge....  Will bisect.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I'd really like to know how this ended up in Parser instead of, say, General, btw.  ;)

Comment 4

[Alice0775 White]

In Error Console:
Error: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them
Source file: http://www.intel.com/sites/js/INTEL.js
Line: 9

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/4192ba38ebee
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre ID:20100820130619
Fails:
http://hg.mozilla.org/mozilla-central/rev/cbf6e0a17783
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre ID:20100820190548
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4192ba38ebee&tochange=cbf6e0a17783

Comment 5

[Alice0775 White]

Regression window of TM build:
Works:
http://hg.mozilla.org/tracemonkey/rev/af8d71b0de3b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100817 Minefield/4.0b4pre ID:20100817043016
Fails:
http://hg.mozilla.org/tracemonkey/rev/27a70c60b48d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100818 Minefield/4.0b4pre ID:20100818065537
Pushlog:
http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=af8d71b0de3b&tochange=27a70c60b48d

Comment 6

[Boris Zbarsky [:bzbarsky]]

The first bad revision is:
changeset:   51092:981c0f32ff15
user:        Jeff Walden <[e-mail]>
date:        Wed Aug 04 14:39:45 2010 -0700
summary:     Bug 514563 - ES5 strict mode: arguments.caller and arguments.callee poison pills.  r=dmandelin

And indeed, the error console (which I should've checked, doh!) says:

  Error: 'caller', 'callee', and 'arguments' properties may not be accessed on
  strict mode functions or the arguments objects for calls to them
  Source File: http://www.intel.com/sites/js/INTEL.js
  Line: 9

The .js file in question does in fact have "use strict;" at the top, and uses callee all over the place.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I sent intel mail via their contact form; we'll see how it goes.

Comment 8

[Brendan Eich [:brendan]]

Eek. Moh, any ideas on finding whoever at (or working on contract for) Intel added "use strict"; to the front of that line?

http://www.intel.com/sites/js/INTEL.js

Cc'ing jresig in case he knows of some popular movement to sprinkle "use strict"; at the front of scripts, even if doing so breaks those scripts.

I agree that this must be a TE bug.

/be

Comment 9

[Moh Haghighat]

I'll investigate right away.

Comment 10

[Moh Haghighat]

This helped alert our IT folks to this potential problem as "Use Strict" is possibly used in other JavaScript files on our web properties. An effort is underway to scan our source code for all instances of this use.

Many thanks for bringing this to our attention.

- moh

Comment 11

[Marek Stępień [:marcoos, inactive]]

Douglas Crockford's JSLint.com service tells you to add the "use strict" pragma if you choose the "Good Parts" option. Unfortunately, JSLint says there's nothing wrong with code like this:

/*global window */
"use strict";

function someFun() {
    window.alert(arguments.callee);
}

someFun();

Comment 12

[Moh Haghighat]

Hi Brendan & Boris,

Your suggested fix of removing "use strict"; was pushed as part of today's publishing job on Intel site.

Many thanks for your help.

-moh

Comment 13

[Scoobidiver (away)]

I confirm that it works.
So WFM.