594107 - fennec does not release memory when closed

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u367160]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100724 Firefox/3.6.8 GTB7.1
Build Identifier: 



after I export XPCOM_MEM_LEAK_LOG="leak.log" and just started fennec and closed I have attached leak.log with 774 entries leaked total 991519 bytes of memory.

also I noticed following in console output:
WARNING: unable to Flush() diry datasource during XPCOM shutdown: file /home/user/mozilla/mozilla-central/rdf/base/src/nsRDFXMLDataSource.cpp, line 778

and a list of leaking urls.


Reproducible: Always

Steps to Reproduce:
preconditions:

built fennec from mozilla-central 52094:ca371593d433 mobile-browser 1889:aeb8aa5a377f on linux with enabling ac_add_options --enable-logging ac_add_options --enable-logrefcnt.

Comment 1

[u367160]

Attachment: leak.log

leak.log

Comment 2

[u367160]

Attachment: console.log

Comment 3

[Ayan Shah[:ashah]]

mfinkle, 
what do you think about this bug? Is more information needed on this?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

We need to get a handle on this problem as soon as possible. Fennec leaks like this just opening and closing - no need to do anything else.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

With this patch, Fennec will shutdown without any leaks.

The patch removes message listeners attached to the main window. Opening and closing Fennec shows no leaks.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 476917 [details] [diff] [review]
patch

I found more we should release, just to be safe.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 476917 [details] [diff] [review]
patch

Actually, this patch seems to be all that is needed to make Fennec close without leeaks. Even though we attach message listeners to the main window in browser-ui.js, those seem to have no affect on the leak behavior during shutdown.

In fact, even if I only remove three of the five listeners in this patch, Fennec closes without leaks. Maybe the cycle collector is coming into play here?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: unlink some more

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477113 [details] [diff] [review]
unlink some more

This patch was not enough to prevent the shutdown leaks.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477113 [details] [diff] [review]
unlink some more

Doesn't work as intended

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/aba05d111c4a