594138 - TM: testConservativeGC fails with gczeal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregor Wagner [:gwagner]]

on current tip with gczeal = 2 enabled.

testConservativeGC
../../jsapi-tests/testConservativeGC.cpp:39:CHECK failed: !memcmp(&objCopy, JSVAL_TO_OBJECT(v2), sizeof(objCopy))
TEST-UNEXPECTED-FAIL | testConservativeGC | CHECK failed: !memcmp(&objCopy, JSVAL_TO_OBJECT(v2), sizeof(objCopy))

Comment 1

[Igor Bukanov]

> on current tip with gczeal = 2 enabled.

This is a JS_THREADSAFE build, right?

Comment 2

[Gregor Wagner [:gwagner]]

It fails in a normal (no threadsafe) debug build for me.

Comment 3

[Igor Bukanov]

Attachment: v1

This is a fallout from JSScope elimination. Now JSObject contains the shape field and that field can change under the GC. So the test cannot not use memcmp to check if the content of JSObject remains the same after the GC.

Comment 4

[Igor Bukanov]

(In reply to comment #0)
> on current tip with gczeal = 2 enabled.

How do you enable gczeal for tests? I had to do it via an explicit JS_SetGCZeal in tests.cpp.

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 473498 [details] [diff] [review]
v1

How about keeping the memcmp but copying objShape over first?

/be

Comment 6

[Igor Bukanov]

Attachment: v2

This implements Brendan's idea.

Comment 7

[Gregor Wagner [:gwagner]]

Comment on attachment 473687 [details] [diff] [review]
v2

>diff --git a/js/src/jsapi-tests/testConservativeGC.cpp b/js/src/jsapi-tests/testConservativeGC.cpp
>--- a/js/src/jsapi-tests/testConservativeGC.cpp
>+++ b/js/src/jsapi-tests/testConservativeGC.cpp
>@@ -30,18 +30,31 @@ BEGIN_TEST(testConservativeGC)
>     JS_GC(cx);
> 
>     EVAL("var a = [];\n"
>          "for (var i = 0; i != 10000; ++i) {\n"
>          "a.push(i + 0.1, [1, 2], String(Math.sqrt(i)));\n"
>          "}", &tmp);
> 
>     JS_GC(cx);
> 
>-    CHECK(!memcmp(&objCopy,  JSVAL_TO_OBJECT(v2), sizeof(objCopy)));
>+    checkObjectFields(&objCopy,  JSVAL_TO_OBJECT(v2));

Why are there 2 spaces?

Comment 8

[Gregor Wagner [:gwagner]]

(In reply to comment #4)
> (In reply to comment #0)
> > on current tip with gczeal = 2 enabled.
> 
> How do you enable gczeal for tests? I had to do it via an explicit JS_SetGCZeal
> in tests.cpp.

I have a working space where it is hardcoded in the runtime init.

Comment 9

[Igor Bukanov]

http://hg.mozilla.org/tracemonkey/rev/a1f43f4ef565 - pushed with a fix to testIsAboutToBeFinalized.cpp with a workaround to make sure to overwrite machine registers.

Comment 10

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/a1f43f4ef565