Subdirectories of js/src are compiled with -O, not -O3 or -Os.

NEW
Unassigned

Status

9 years ago
a year ago

People

(Reporter: justin.lebar+bug, Unassigned)

Tracking

Trunk
ARM
Android

Firefox Tracking Flags

(Not tracked)

Details

js/src/configure.in doesn't set optimize flags for Android.  js/src/Makefile.in specifies MODULE_OPTIMIZE_FLAGS=-O3, but that doesn't apply recursively.  Thus subdirectories such as js/src/shell get the default, -O, instead of -O3 (or -Os), which is preferable.

For instance, search for js.o in [1].

[1] http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1283889190.1283897179.16812.gz&fulltext=1
(Reporter)

Updated

9 years ago
Summary: Subdirectories of js/src are not → Subdirectories of js/src are compiled with -O, not -O3 or -Os.
Probably doesn't matter all that much. We're not actually shipping those, and I'm not sure you can even run the JS shell on Android.
The important subdirectories don't appear to fall victim to this.  The nanojit and webkit assembler dirs have -g -O3
How about editline?
Whoops--accidentally pressed enter.  I meant to say that that appears to be part of jsshell as well.

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.