Closed
Bug 594267
Opened 14 years ago
Closed 14 years ago
don't call WillPaint on hidden documents
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(2 files)
|
6.55 KB,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
|
1.96 KB,
patch
|
bzbarsky
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
This was reported in bug 593457 comment 2, comment 7. A description of the problem and solution is in comment 8.
|
||
Comment 1•14 years ago
|
||
Bailing from WillPaint if not active is totally the right thing to do. Timothy, are you planning to patch, or does this need another owner?
|
Assignee | |
Comment 2•14 years ago
|
||
I have patches :). Will post soon.
|
|
Assignee | |
Comment 3•14 years ago
|
||
This hack was used to jump the chrome/content view manager gap by using the docshell tree to determine if a document is visible. nsDocShell::GetVisibility now just ends up just getting basically the same information from the view tree. So just use the view tree directly.
Assignee: nobody → tnikkel
Attachment #472951 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Checking for hidden root view and active presshell is probably redundant. But, I think, better safe than sorry.
Attachment #472952 -
Flags: review?(bzbarsky)
Attachment #472951 -
Flags: review?(roc) → review+
|
||
Updated•14 years ago
|
blocking2.0: --- → ?
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 472952 [details] [diff] [review]
don't send WillPaint to hidden documents
Fix the comment at the beginning of WillPaint?
Attachment #472952 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
(In reply to comment #5)
> Fix the comment at the beginning of WillPaint?
Will do.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #472951 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #472952 -
Flags: approval2.0?
Attachment #472951 -
Flags: approval2.0? → approval2.0+
Attachment #472952 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/fe115cf401df
http://hg.mozilla.org/mozilla-central/rev/da46598b1382
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
You need to log in
before you can comment on or make changes to this bug.
Description
•