Closed Bug 594267 Opened 9 years ago Closed 9 years ago

don't call WillPaint on hidden documents

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This was reported in bug 593457 comment 2, comment 7. A description of the problem and solution is in comment 8.
Bailing from WillPaint if not active is totally the right thing to do. Timothy, are you planning to patch, or does this need another owner?
I have patches :). Will post soon.
This hack was used to jump the chrome/content view manager gap by using the docshell tree to determine if a document is visible. nsDocShell::GetVisibility now just ends up just getting basically the same information from the view tree. So just use the view tree directly.
Assignee: nobody → tnikkel
Attachment #472951 - Flags: review?(roc)
Checking for hidden root view and active presshell is probably redundant. But, I think, better safe than sorry.
Attachment #472952 - Flags: review?(bzbarsky)
blocking2.0: --- → ?
Comment on attachment 472952 [details] [diff] [review]
don't send WillPaint to hidden documents

Fix the comment at the beginning of WillPaint?
Attachment #472952 - Flags: review?(bzbarsky) → review+
(In reply to comment #5)
> Fix the comment at the beginning of WillPaint?

Will do.
Attachment #472951 - Flags: approval2.0?
Attachment #472952 - Flags: approval2.0?
Blocks: 588402
http://hg.mozilla.org/mozilla-central/rev/fe115cf401df
http://hg.mozilla.org/mozilla-central/rev/da46598b1382
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
blocking2.0: ? → final+
You need to log in before you can comment on or make changes to this bug.