594280 - Firefox does not ask to save tabs and windows on exit

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[JC Yang]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b5) Gecko/20100101 Firefox/4.0b5
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b5) Gecko/20100101 Firefox/4.0b5

While use the new UI(the traditional menu bar is disabled), Firefox does not ask to save tabs and windows on exit. When re-enable the menu bar, everything is ok. I've tested this bug in Safe Mode. All setting are correct and I tested in Safe Mode to reproduce this bug. Menu bar on and off is the key. You should simply reproduce it.

Reproducible: Always

Steps to Reproduce:
1.Run Firefox 4 beta 5 with the new UI(menu bar disabled)
2.Open more than one tabs.
3.Close Firefox.
Actual Results:  
Firefox does not ask to save tabs and windows on exit

Expected Results:  
Firefox should ask to save tabs and windows on exit(with the correct settings).

Comment 1

[JC Yang]

Well, I've just make another test. That seems this bug occur when I close firefox with the (x)close button in the top right corner of the window. If I close the firefox with the exit command in the menu(the new UI menu in the top left corner), everything is ok. All these behaviors are discovered in the new UI(menu bar disabled).

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #0)
> Steps to Reproduce:
> 1.Run Firefox 4 beta 5 with the new UI(menu bar disabled)
> 2.Open more than one tabs.
> 3.Close Firefox.
> Actual Results:  
> Firefox does not ask to save tabs and windows on exit
> 
> Expected Results:  
> Firefox should ask to save tabs and windows on exit(with the correct settings).

How are you closing Firefox here? Were you closing with the X or with "exit" in the menu?

It would surprise me that this is specific to the new menu. Turn the menubar off and see if the same thing happens.

Comment 3

[JC Yang]

Just as I said in my 2nd post, it's a bug with 'x' button in the top right corner. The 'exit' command in the new menu doesn't have this problem.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Try with the exit command in the old menu.

Do you have Firefox set to clear history when quitting?

Are you sure this only happens with the new version of Firefox?

Comment 5

[aravindm]

Mozilla/5.0 (Windows NT 5.1; rv:2.0b5) Gecko/20100101 Firefox/4.0b5

Able to reproduce. Firefox with the new UI(menu bar disabled) and with more than one tab opened, closes without any warning when clicking on 'x' button in the top right corner. This happens only in Firefox 4.0b5. With the exit command, it works fine. 
It works fine with the latest trunk build Firefox 4.0b6pre.

Comment 6

[Chris Jones]

I've reproduced it as well on a freshly installed FF 4.0 b5 with a new, unmodified profile with every setting at default values except for turning off the traditional menu bar in favor of the orange menu button.  Closing the browser with the close button (X) gives no option to save the current tabs.  Turning on the menu bar in lieu of the orange button will cause the "save current tabs" feature to start working as expected.

Comment 7

[JC Yang]

The bug is still there in the latest beta 6.
Is there anyone going to take this?

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I still don't think I've seen this... Can you try with with a recent nightly? http://nightly.mozilla.org

Comment 9

[Chris Jones]

Beta 6 does still fail to offer to save open tabs when closing using the close button when the menu bar isn't displayed.  The most recent Minefield, though, works as it should.  This must have been fixed somewhere along since beta 6.

Comment 10

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

bandinfinite, it would be great if you could also confirm that this works in the nightlies since beta 6.

Comment 11

[B.J. Herbison]

I just tested using Windows 7 and Ubuntu 10.10 and I was unable to reproduce this behavior. In every test I was asked about saving tabs.

Comment 12

[B.J. Herbison]

Sorry, I forgot to mention: Firefox 4 beta 8 pre -- the latest nightly installed the morning of 8 December 2010.

Comment 13

[u279076]

Resolving WORKSFORME.  Please reopen if you can reproduce this on a recent build.